From mboxrd@z Thu Jan 1 00:00:00 1970 From: julien.grall@linaro.org (Julien Grall) Date: Wed, 18 Feb 2015 11:50:35 +0000 Subject: [PATCH 1/2] arm/xen: Correctly check if the event channel interrupt is present In-Reply-To: <54E47A80.9050208@linaro.org> References: <1423722898-16110-1-git-send-email-julien.grall@linaro.org> <1423722898-16110-2-git-send-email-julien.grall@linaro.org> <1424258866.27775.15.camel@citrix.com> <54E47A80.9050208@linaro.org> Message-ID: <54E47C8B.1080205@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/02/2015 11:41, Julien Grall wrote: > Hi Ian, > > On 18/02/2015 11:27, Ian Campbell wrote: >> On Thu, 2015-02-12 at 06:34 +0000, Julien Grall wrote: >>> The function irq_of_parse_and_map returns 0 when the IRQ is not found. >>> >>> Furthermore xen_events_irq is only read when the CPU is bring up, so >>> it's not necessary to use the attribute __read_mostly. >> >> Part of the purpose of __read_mostly is to move such things out of >> sharing cachelines with other more hot read/write things, as much as it >> is to group all the "read only" things together. > > Hmmm... You are right. I didn't understand this macro like that. > > I will resend the series with this patch drop and add Ard's patch [1]. Actually I'm stupid... This patch is still useful except the __read_mostly. > > Regards, > > [1] https://patches.linaro.org/44633/ > -- Julien Grall From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 1/2] arm/xen: Correctly check if the event channel interrupt is present Date: Wed, 18 Feb 2015 11:50:35 +0000 Message-ID: <54E47C8B.1080205@linaro.org> References: <1423722898-16110-1-git-send-email-julien.grall@linaro.org> <1423722898-16110-2-git-send-email-julien.grall@linaro.org> <1424258866.27775.15.camel@citrix.com> <54E47A80.9050208@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YO39K-0006ps-Va for xen-devel@lists.xenproject.org; Wed, 18 Feb 2015 11:50:39 +0000 Received: by wesu56 with SMTP id u56so606933wes.10 for ; Wed, 18 Feb 2015 03:50:37 -0800 (PST) In-Reply-To: <54E47A80.9050208@linaro.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, ard.biesheuvel@linaro.org, linux-arm-kernel@lists.infradead.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 18/02/2015 11:41, Julien Grall wrote: > Hi Ian, > > On 18/02/2015 11:27, Ian Campbell wrote: >> On Thu, 2015-02-12 at 06:34 +0000, Julien Grall wrote: >>> The function irq_of_parse_and_map returns 0 when the IRQ is not found. >>> >>> Furthermore xen_events_irq is only read when the CPU is bring up, so >>> it's not necessary to use the attribute __read_mostly. >> >> Part of the purpose of __read_mostly is to move such things out of >> sharing cachelines with other more hot read/write things, as much as it >> is to group all the "read only" things together. > > Hmmm... You are right. I didn't understand this macro like that. > > I will resend the series with this patch drop and add Ard's patch [1]. Actually I'm stupid... This patch is still useful except the __read_mostly. > > Regards, > > [1] https://patches.linaro.org/44633/ > -- Julien Grall