From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume Date: Wed, 18 Feb 2015 13:02:23 +0100 Message-ID: <54E47F4F.9090500@vodafone.de> References: <1423773026-5941-1-git-send-email-ross.zwisler@linux.intel.com> <54DD6469.9060809@daenzer.net> <1423886115.5037.12.camel@theros.lm.intel.com> <1424195346.12687.6.camel@theros.lm.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from pegasos-out.vodafone.de (pegasos-out.vodafone.de [80.84.1.38]) by gabe.freedesktop.org (Postfix) with ESMTP id B9DD36E07D for ; Wed, 18 Feb 2015 04:02:34 -0800 (PST) In-Reply-To: <1424195346.12687.6.camel@theros.lm.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ross Zwisler , "Deucher, Alexander" Cc: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dave Airlie , Lauri Kasanen , "Koenig, Christian" List-Id: dri-devel@lists.freedesktop.org T24gMTcuMDIuMjAxNSAxODo0OSwgUm9zcyBad2lzbGVyIHdyb3RlOgo+IE9uIFNhdCwgMjAxNS0w Mi0xNCBhdCAwNjoyNSArMDAwMCwgRGV1Y2hlciwgQWxleGFuZGVyIHdyb3RlOgo+Pj4gLS0tLS1P cmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4+IEZyb206IFJvc3MgWndpc2xlciBbbWFpbHRvOnJvc3Mu endpc2xlckBsaW51eC5pbnRlbC5jb21dCj4+PiBTZW50OiBGcmlkYXksIEZlYnJ1YXJ5IDEzLCAy MDE1IDEwOjU1IFBNCj4+PiBUbzogTWljaGVsIETDpG56ZXIKPj4+IENjOiBsaW51eC1rZXJuZWxA dmdlci5rZXJuZWwub3JnOyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBEZXVjaGVy LAo+Pj4gQWxleGFuZGVyOyBEYXZlIEFpcmxpZTsgTGF1cmkgS2FzYW5lbjsgS29lbmlnLCBDaHJp c3RpYW4KPj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRybS9yYWRlb246IEZpeCByZWdyZXNzaW9u IHdpdGggc3VzcGVuZC9yZXN1bWUKPj4+Cj4+PiBPbiBGcmksIDIwMTUtMDItMTMgYXQgMTE6NDEg KzA5MDAsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+Pj4+IE9uIDEzLjAyLjIwMTUgMDU6MzAsIFJv c3MgWndpc2xlciB3cm90ZToKPj4+Pj4gVGhpcyBwYXRjaCByZXZlcnRzIHRoZSBjaGFuZ2VzIG1h ZGUgaW4gdGhpcyBjb21taXQ6Cj4+Pj4+Cj4+Pj4+ICAgIGRlYWRjYjM2ZjQ5YiAoImRybS9yYWRl b246IFVzZSB0d28tZW5kZWQgYWxsb2NhdGlvbiBieSBzaXplLCB2MiIpCj4+Pj4+Cj4+Pj4+IFRo YXQgcGF0Y2ggY2F1c2VkIGEgcmVncmVzc2lvbiBvbiBteSBzeXN0ZW0gd2hlcmUgdGhlIGJvdHRv bSBvZiB0aGUKPj4+Pj4gc2NyZWVuIGZsaWNrZXJzIGFmdGVyIG15IGxhcHRvcCBnb2VzIHRob3Jv dWdoIGEgc3VzcGVuZCBhbmQgcmVzdW1lLgo+Pj4+IFdoYXQga2luZCBvZiBmbGlja2VyIGlzIGl0 PyBFLmcuIGRvZXMgaXQgb25seSBhZmZlY3QgWCBvciBhbHNvIGNvbnNvbGUsCj4+Pj4gZG9lcyBp dCBmbGlja2VyIGFsbCB0aGUgdGltZSBvciBvbmx5IHdoZW4gdGhlcmUgaXMgYWN0aXZpdHksIHdo YXQgZG9lcwo+Pj4+IGl0IGxvb2sgbGlrZSwgLi4uCj4+PiBJdCdzIGtpbmQgb2YgaGFyZCB0byBk ZXNjcmliZSBpdCBwcmVjaXNlbHksIHNvIEkgbWFkZSBhIHZpZGVvLiAgOikKPj4+Cj4+PiBodHRw Oi8veW91dHUuYmUvRVNtOVNNbnIwZG8KPj4+Cj4+PiBJdCBvbmx5IGFmZmVjdHMgWCwgbm90IHRo ZSBjb25zb2xlLCBhbmQgaXQgc2VlbXMgdG8gZ28gYXdheSBpZiB5b3UgbG9nCj4+PiBvdXQgYmFj ayB0byB0aGUgbG9naW4gbWFuYWdlciAoSSdtIHVzaW5nIEdETSBvbiBGZWRvcmEgMjApIGFuZCBi YWNrIGludG8KPj4+IHlvdXIgd2luZG93IG1hbmFnZXIuCj4+IERvZXMgYSBWVCBzd2l0Y2ggb3Ig Zm9yY2luZyBhIGRwbXMgY3ljbGUgKHNsZWVwIDU7IHhzZXQgZHBtcyBmb3JjZSBvZmYpCj4+IGFs c28gZml4IGl0PyAgSXQgZG9lc24ndCBsb29rIHJlbGF0ZWQgdG8gdGhlIHBhdGNoIGluIHF1ZXN0 aW9uIGF0IGFsbC4KPj4gSXMgdGhlIGZsaWNrZXJpbmcgMTAwJSByZXByb2R1Y2libGUgb3IgZG9l cyBpdCBvbmx5IGhhcHBlbgo+PiBwZXJpb2RpY2FsbHk/Cj4gIEZyb20ga2VybmVscyAzLjE0IG9y IHNvICh3aGVuIHRoZSBkZWFkY2IzNmY0OWIgcGF0Y2ggd2FzIGludHJvZHVjZWQpCj4gdGlsbCAz LjE4IGl0IGhhcHBlbmVkIDEwMCUgb2YgdGhlIHRpbWUuICBXaXRoIDMuMTkgaXQgb25seSBzZWVt cyB0bwo+IGhhcHBlbiBtYXliZSA1MCUgb2YgdGhlIHRpbWUsIGJ1dCBpcyBzdGlsbCB2ZXJ5IGVh c2lseSByZXByb2R1Y2libGUuCgpXZWxsLCB3aGF0IHRoZSBwYXRjaCBkb2VzIGlzIGp1c3QgY2hh bmdpbmcgd2hlcmUgYnVmZmVycyBhcmUgcGxhY2VkIGluIAptZW1vcnkuIEUuZy4gbm93IHdlIHBs YWNlIHRoZSBidWZmZXIgYXQgdGhlIGVuZCBvZiBtZW1vcnkgYXMgd2VsbC4KClNvIEkgY2FuIGlt YWdpbmUgYXQgbGVhc3QgdGhyZWUgcG9zc2libGUgY2F1c2VzIGZvciB0aGUgaXNzdWVzIHlvdSBz ZWU6CjEuIFdlIGhhdmVuJ3QgaW1wbGVtZW50ZWQgYWxsIGJ1ZmZlciBwbGFjZW1lbnQgcmVzdHJp Y3Rpb25zIGNvcnJlY3RseSAKYW5kIHdpdGhvdXQgdGhlIHBhdGNoIGV2ZXJ5dGhpbmcganVzdCB3 b3JrcyBmaW5lIGJ5IGNvaW5jaWRlbnQuCjIuIFNvbWV0aGluZyBpcyBvdmVyd3JpdGluZyB0aGUg YnVmZmVyIGF0IGl0J3MgbmV3IGxvY2F0aW9uLiAKQEFsZXgmTWljaGVsOiBEaWRuJ3Qgd2UgaGFk IGEgc2ltaWxhciBwcm9ibGVtIGludGVybmFsbHkgcmVjZW50bHk/IE9yIAp3YXMgdGhhdCBqdXN0 IGZvciBBUFVzPwozLiBPbmUgb2YgdGhlIG1lbW9yeSBjaGlwcyBvbiB5b3VyIGhhcmR3YXJlIGlz IGZhdWx0eSBhbmQgd2l0aG91dCB0aGUgCnBhdGNoIHRoZSB3ZSBqdXN0IGRvbid0IHVzZSB0aGUg YWZmZWN0ZWQgcmVnaW9uIChyYXRoZXIgdW5saWtlbHkpLgoKRm9yIHRlc3RpbmcgY291bGQgeW91 IHRyeSB0byBsaW1pdCB0aGUgYW1vdW50IG9mIFZSQU0gdXNlZD8gRS5nLiBnaXZlIApyYWRlb24u dnJhbWxpbWl0PTI1NiBhcyBrZXJuZWwgY29tbWFuZGxpbmUgdG8gbGltaXQgdGhlIFZSQU0gdG8g dGhlIApmaXJzdCAyNTZNQi4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiBJdCdzIGVudGlyZWx5 IHBvc3NpYmxlIHRoYXQgdGhlIHBhdGNoIGlzbid0IHRoZSByb290IGNhdXNlLCBidXQgaXQganVz dAo+IGJyb3VnaHQgb3V0IGEgYnVnIHNvbWV3aGVyZSBlbHNlLiAgQWxsIEkga25vdyBpcyB0aGF0 IEkgZGlkIGEgYmlzZWN0LAo+IGFuZCB3aXRoIHRoZSBjb21taXQgYmVmb3JlIHRoaXMgdGhlIGlz c3VlIG5ldmVyIGhhcHBlbnMsIGFuZCBhZnRlciB0aGlzCj4gY29tbWl0IGl0IGhhcHBlbnMgMTAw JSBvZiB0aGUgdGltZS4gOikgIEFsc28sIHJldmVydGluZyB0aGF0IGNvbW1pdCB3aXRoCj4gMy4x OSBtYWtlcyB0aGUgaXNzdWUgZ28gYXdheS4KPgo+IE5vcGUsICJ4c2V0IGRwbXMgZm9yY2Ugb2Zm IiBkb2Vzbid0IGZpeCBpdC4gQWZ0ZXIgdGhlIHNjcmVlbiBnb2VzIGJsYWNrCj4gYW5kIGNvbWVz IGJhY2ssIHRoZSBmbGlja2VyIGlzIHN0aWxsIHRoZXJlLgo+Cj4gLSBSb3NzCj4KPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752133AbbBRMJF (ORCPT ); Wed, 18 Feb 2015 07:09:05 -0500 Received: from pegasos-out.vodafone.de ([80.84.1.38]:42789 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbBRMJD (ORCPT ); Wed, 18 Feb 2015 07:09:03 -0500 X-Greylist: delayed 387 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Feb 2015 07:09:02 EST X-Spam-Flag: NO X-Spam-Score: -0.054 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de 0D6A2E65FA Message-ID: <54E47F4F.9090500@vodafone.de> Date: Wed, 18 Feb 2015 13:02:23 +0100 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Ross Zwisler , "Deucher, Alexander" CC: =?UTF-8?B?TWljaGVsIETDpG56ZXI=?= , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dave Airlie , Lauri Kasanen , "Koenig, Christian" Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume References: <1423773026-5941-1-git-send-email-ross.zwisler@linux.intel.com> <54DD6469.9060809@daenzer.net> <1423886115.5037.12.camel@theros.lm.intel.com> <1424195346.12687.6.camel@theros.lm.intel.com> In-Reply-To: <1424195346.12687.6.camel@theros.lm.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17.02.2015 18:49, Ross Zwisler wrote: > On Sat, 2015-02-14 at 06:25 +0000, Deucher, Alexander wrote: >>> -----Original Message----- >>> From: Ross Zwisler [mailto:ross.zwisler@linux.intel.com] >>> Sent: Friday, February 13, 2015 10:55 PM >>> To: Michel Dänzer >>> Cc: linux-kernel@vger.kernel.org; dri-devel@lists.freedesktop.org; Deucher, >>> Alexander; Dave Airlie; Lauri Kasanen; Koenig, Christian >>> Subject: Re: [PATCH] drm/radeon: Fix regression with suspend/resume >>> >>> On Fri, 2015-02-13 at 11:41 +0900, Michel Dänzer wrote: >>>> On 13.02.2015 05:30, Ross Zwisler wrote: >>>>> This patch reverts the changes made in this commit: >>>>> >>>>> deadcb36f49b ("drm/radeon: Use two-ended allocation by size, v2") >>>>> >>>>> That patch caused a regression on my system where the bottom of the >>>>> screen flickers after my laptop goes thorough a suspend and resume. >>>> What kind of flicker is it? E.g. does it only affect X or also console, >>>> does it flicker all the time or only when there is activity, what does >>>> it look like, ... >>> It's kind of hard to describe it precisely, so I made a video. :) >>> >>> http://youtu.be/ESm9SMnr0do >>> >>> It only affects X, not the console, and it seems to go away if you log >>> out back to the login manager (I'm using GDM on Fedora 20) and back into >>> your window manager. >> Does a VT switch or forcing a dpms cycle (sleep 5; xset dpms force off) >> also fix it? It doesn't look related to the patch in question at all. >> Is the flickering 100% reproducible or does it only happen >> periodically? > From kernels 3.14 or so (when the deadcb36f49b patch was introduced) > till 3.18 it happened 100% of the time. With 3.19 it only seems to > happen maybe 50% of the time, but is still very easily reproducible. Well, what the patch does is just changing where buffers are placed in memory. E.g. now we place the buffer at the end of memory as well. So I can imagine at least three possible causes for the issues you see: 1. We haven't implemented all buffer placement restrictions correctly and without the patch everything just works fine by coincident. 2. Something is overwriting the buffer at it's new location. @Alex&Michel: Didn't we had a similar problem internally recently? Or was that just for APUs? 3. One of the memory chips on your hardware is faulty and without the patch the we just don't use the affected region (rather unlikely). For testing could you try to limit the amount of VRAM used? E.g. give radeon.vramlimit=256 as kernel commandline to limit the VRAM to the first 256MB. Regards, Christian. > > It's entirely possible that the patch isn't the root cause, but it just > brought out a bug somewhere else. All I know is that I did a bisect, > and with the commit before this the issue never happens, and after this > commit it happens 100% of the time. :) Also, reverting that commit with > 3.19 makes the issue go away. > > Nope, "xset dpms force off" doesn't fix it. After the screen goes black > and comes back, the flicker is still there. > > - Ross > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel