From: Karol Wrona <k.wrona@samsung.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning
Date: Wed, 18 Feb 2015 13:41:14 +0100 [thread overview]
Message-ID: <54E4886A.5080902@samsung.com> (raw)
In-Reply-To: <1424259586-29334-1-git-send-email-geert@linux-m68k.org>
On 02/18/2015 12:39 PM, Geert Uytterhoeven wrote:
> If CONFIG_PM_SLEEP=n:
>
> drivers/iio/common/ssp_sensors/ssp_dev.c:644: warning: ‘ssp_suspend’ defined but not used
> drivers/iio/common/ssp_sensors/ssp_dev.c:669: warning: ‘ssp_resume’ defined but not used
>
> Protect the unused functions by #ifdef CONFIG_PM_SLEEP to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> v2:
> - Fix driver name in one-line summary
> ---
> drivers/iio/common/ssp_sensors/ssp_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/common/ssp_sensors/ssp_dev.c b/drivers/iio/common/ssp_sensors/ssp_dev.c
> index 52d70435f5a11c55..55a90082a29bd484 100644
> --- a/drivers/iio/common/ssp_sensors/ssp_dev.c
> +++ b/drivers/iio/common/ssp_sensors/ssp_dev.c
> @@ -640,6 +640,7 @@ static int ssp_remove(struct spi_device *spi)
> return 0;
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int ssp_suspend(struct device *dev)
> {
> int ret;
> @@ -688,6 +689,7 @@ static int ssp_resume(struct device *dev)
>
> return 0;
> }
> +#endif /* CONFIG_PM_SLEEP */
>
> static const struct dev_pm_ops ssp_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(ssp_suspend, ssp_resume)
>
Acked-by: Karol Wrona <k.wrona@samsung.com>
Thanks for doing that.
Karol
next prev parent reply other threads:[~2015-02-18 12:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 11:39 [PATCH v2] iio: common: ssp_sensors: Protect PM-only functions to kill warning Geert Uytterhoeven
2015-02-18 12:41 ` Karol Wrona [this message]
2015-02-22 9:48 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E4886A.5080902@samsung.com \
--to=k.wrona@samsung.com \
--cc=geert@linux-m68k.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.