From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO54y-00040h-QH for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:54:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO54u-0003HA-OC for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:54:16 -0500 Received: from mail-wg0-x22d.google.com ([2a00:1450:400c:c00::22d]:37156) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO54u-0003H4-CT for qemu-devel@nongnu.org; Wed, 18 Feb 2015 08:54:12 -0500 Received: by mail-wg0-f45.google.com with SMTP id k14so1304420wgh.4 for ; Wed, 18 Feb 2015 05:54:11 -0800 (PST) Sender: Paolo Bonzini Message-ID: <54E4997A.6020606@redhat.com> Date: Wed, 18 Feb 2015 14:54:02 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20150218115534.4176.12578.stgit@PASHA-ISP> <20150218115633.4176.67664.stgit@PASHA-ISP> In-Reply-To: <20150218115633.4176.67664.stgit@PASHA-ISP> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v9 09/23] replay: interrupts and exceptions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Pavel Dovgalyuk , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, mark.burton@greensocs.com, real@ispras.ru, batuzovk@ispras.ru, maria.klimushenkova@ispras.ru, alex.bennee@linaro.org, afaerber@suse.de, fred.konrad@greensocs.com On 18/02/2015 12:56, Pavel Dovgalyuk wrote: > +{ > + bool res = false; > + if (replay_mode == REPLAY_MODE_PLAY) { > + replay_account_executed_instructions(); > + replay_mutex_lock(); > + if (skip_async_events(EVENT_EXCEPTION)) { > + res = true; > + } Just "res = skip_async_events(EVENT_EXCEPTION)" is simpler. Paolo > + replay_mutex_unlock(); > + } > +