Re: [PATCH] xen: arm64: more useful logging on bad trap.

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 18/02/2015 15:19, Ian Campbell wrote:
> diff --git a/xen/arch/arm/arm64/traps.c b/xen/arch/arm/arm64/traps.c
> index 1693b5d..89b8eb3 100644
> --- a/xen/arch/arm/arm64/traps.c
> +++ b/xen/arch/arm/arm64/traps.c
> @@ -24,11 +24,6 @@
>
>   #include <public/xen.h>
>
> -asmlinkage void do_trap_serror(struct cpu_user_regs *regs)
> -{
> -    panic("Unhandled serror trap");
> -}
> -
>   static const char *handler[]= {
>           "Synchronous Abort",
>           "IRQ",
> @@ -38,11 +33,13 @@ static const char *handler[]= {
>
>   asmlinkage void do_bad_mode(struct cpu_user_regs *regs, int reason)
>   {
> -    uint64_t esr = READ_SYSREG64(ESR_EL2);
> -    printk("Bad mode in %s handler detected, code 0x%08"PRIx64"\n",
> -           handler[reason], esr);

While you are modifying this function. Can you add a newline after the 
declarations?

Other than that:

Reviewed-by: Julien Grall <julien.grall@linaro.org>

Regards,

-- 
Julien Grall