From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO8hL-00056S-Hs for qemu-devel@nongnu.org; Wed, 18 Feb 2015 12:46:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO8hH-0004vr-8y for qemu-devel@nongnu.org; Wed, 18 Feb 2015 12:46:07 -0500 Received: from cantor2.suse.de ([195.135.220.15]:48973 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO8hH-0004vm-1p for qemu-devel@nongnu.org; Wed, 18 Feb 2015 12:46:03 -0500 Message-ID: <54E4CFCF.5060408@suse.de> Date: Wed, 18 Feb 2015 18:45:51 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1424167806-8372-1-git-send-email-zhaoshenglong@huawei.com> <1424167806-8372-6-git-send-email-zhaoshenglong@huawei.com> In-Reply-To: <1424167806-8372-6-git-send-email-zhaoshenglong@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 5/7] target-arm/cpu: Add apic_id property for ARMCPU List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shannon Zhao Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, a.spyridakis@virtualopensystems.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, wanghaibin.wang@huawei.com, peter.huangpeng@huawei.com, hanjun.guo@linaro.org, imammedo@redhat.com, pbonzini@redhat.com, lersek@redhat.com, christoffer.dall@linaro.org Hi, Am 17.02.2015 um 11:10 schrieb Shannon Zhao: > Add apic_id property for ARMCPU. It can be used for cpu hotplug. >=20 > Signed-off-by: Shannon Zhao > --- > target-arm/cpu-qom.h | 1 + > target-arm/cpu.c | 77 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > target-arm/cpu.h | 2 + > 3 files changed, 80 insertions(+), 0 deletions(-) >=20 > diff --git a/target-arm/cpu-qom.h b/target-arm/cpu-qom.h > index ed5a644..d4560e2 100644 > --- a/target-arm/cpu-qom.h > +++ b/target-arm/cpu-qom.h > @@ -59,6 +59,7 @@ typedef struct ARMCPU { > /*< public >*/ > =20 > CPUARMState env; > + uint32_t apic_id; Can you add a matching @apic_id: documentation entry above the struct? > =20 > /* Coprocessor information */ > GHashTable *cp_regs; > diff --git a/target-arm/cpu.c b/target-arm/cpu.c > index 285947f..9202b07 100644 > --- a/target-arm/cpu.c > +++ b/target-arm/cpu.c [...] > @@ -343,6 +407,11 @@ static void arm_cpu_initfn(Object *obj) > cpu->cp_regs =3D g_hash_table_new_full(g_int_hash, g_int_equal, > g_free, g_free); > =20 > + object_property_add(obj, "apic-id", "int", > + arm_cpuid_get_apic_id, > + arm_cpuid_set_apic_id, NULL, NULL, NULL); The property is correctly called apic-id. Please update the commit message, which has it as apic_id (2x). Regards, Andreas > + > + cpu->apic_id =3D arm_cpu_apic_id_from_index(cs->cpu_index); > #ifndef CONFIG_USER_ONLY > /* Our inbound IRQ and FIQ lines */ > if (kvm_enabled()) { [snip] --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=FCrnberg)