From: Jes Sorensen <jes.sorensen@gmail.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: Use put_unaligned_le16
Date: Wed, 18 Feb 2015 16:27:30 -0500 [thread overview]
Message-ID: <54E503C2.2030009@gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1502182111570.2248@localhost6.localdomain6>
On 02/18/15 15:12, Julia Lawall wrote:
>> Here, use of variable tim_bitmap_le and variable itself is removed. To be compatible with
>> changes header file is added too.
>
> Your commit message is too long here.
>
> julia
>
I agree!
In general, as a driver maintainer, I would also prefer a text message
explaining what is fixed in a, rather than automated Coccinelle output.
Adding a comment that the issue was discovered using Coccinelle is great
however.
Cheers,
Jes
next prev parent reply other threads:[~2015-02-18 21:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 19:56 [PATCH] Staging: rtl8723au: Use put_unaligned_le16 Vaishali Thakkar
2015-02-18 20:12 ` [Outreachy kernel] " Julia Lawall
2015-02-18 21:27 ` Jes Sorensen [this message]
2015-02-19 3:11 ` Vaishali Thakkar
2015-02-19 7:24 ` Julia Lawall
2015-02-19 8:45 ` Vaishali Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E503C2.2030009@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=outreachy-kernel@googlegroups.com \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.