From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: libxl__device_pci_reset() questions Date: Thu, 19 Feb 2015 15:30:33 +0000 Message-ID: <54E60199.6090006@citrix.com> References: <54E5FA4E0200007800061AB4@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOT3w-0008ON-6w for xen-devel@lists.xenproject.org; Thu, 19 Feb 2015 15:30:48 +0000 In-Reply-To: <54E5FA4E0200007800061AB4@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , Wei Liu , Ian Campbell , Ian Jackson , Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org On 19/02/15 13:59, Jan Beulich wrote: > All, > > in the context of someone seeing "The kernel doesn't support reset > from sysfs for PCI device", is my understanding correct that the lack > of error checking in any caller (perhaps intentional) means that any > of the errors logged from this function are really just warnings, i.e. > don't prevent the assignment from taking place? > > Furthermore I'm puzzled by the function first thing trying to access > a "do_flr" file supposedly made available by the pciback driver, yet > I can't see either the upstream or the old 2.6.18 driver surfacing > such a file. What am I missing here? "do_flr" is an old XenServer-ism. libxl doesn't need to try using it. David