Re: Potential leaks & errors on current trunk

[Jens Axboe <axboe@kernel.dk>]

On 02/19/2015 04:17 AM, Erwan Velu wrote:
>
> Le 18/02/2015 19:36, Jens Axboe a écrit :
>>
>>> http://git.kernel.dk/?p=fio.git;a=blob;f=iolog.c;h=99f8bc18d8694cca0c141c51d116aced1b4130f2;hb=HEAD#l863
>>>
>>>
>>> In that function, if we do return 1 we do leak ic.buf, we shall free it
>>> before the return
>>
>> Yep, there's a potential leak or two there, should be fixed up.
>>
>>> http://git.kernel.dk/?p=fio.git;a=blob;f=lib/axmap.c;h=164300f254014b10ed6e04e3e06b7263aa917aac;hb=HEAD#l127
>>>
>>>
>>> Here, we surely miss the free of the axmap. We did free its internal
>>> structure but not axmap itself.
>>
>> Yes, that should free 'axmap' too of course.
>>
>
> Hey Jens,
>
> I don't know your workflow : do you accept pull request directly on
> github ?

I do, I'm pretty flexible that way.

> At least, please find the two commits for that issues in my repo :
> https://github.com/enovance/fio/tree/erwan/memory-leak

Thanks, applied. But I had to fix up your whitespace, you are using 
spaces instead of tabs.

-- 
Jens Axboe