From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 12/13] xen/iommu: smmu: Add Xen specific
 code to be able to use the driver
Date: Thu, 19 Feb 2015 17:17:26 +0000
Message-ID: <54E61AA6.8070200@linaro.org>
References: <1422643768-23614-1-git-send-email-julien.grall@linaro.org>
	<1422643768-23614-13-git-send-email-julien.grall@linaro.org>
	<alpine.DEB.2.02.1502061250070.29696@kaball.uk.xensource.com>
	<54D8D4D1.102@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta5.messagelabs.com ([195.245.231.135])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YOUjb-0004yk-Uj
	for xen-devel@lists.xenproject.org; Thu, 19 Feb 2015 17:17:56 +0000
Received: by mail-wi0-f178.google.com with SMTP id em10so10698329wid.5
	for <xen-devel@lists.xenproject.org>;
	Thu, 19 Feb 2015 09:17:54 -0800 (PST)
In-Reply-To: <54D8D4D1.102@linaro.org>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org, tim@xen.org, ian.campbell@citrix.com, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

Hi Stefano,

On 09/02/15 15:40, Julien Grall wrote:
>>
>>>   static void arm_smmu_init_context_bank(struct arm_smmu_domain
>>> *smmu_domain)
>>>   {
>>> @@ -757,6 +996,7 @@ static void arm_smmu_init_context_bank(struct
>>> arm_smmu_domain *smmu_domain)
>>>       struct arm_smmu_cfg *cfg = &smmu_domain->cfg;
>>>       struct arm_smmu_device *smmu = smmu_domain->smmu;
>>>       void __iomem *cb_base, *gr0_base, *gr1_base;
>>> +    paddr_t p2maddr;
>>>
>>>       gr0_base = ARM_SMMU_GR0(smmu);
>>>       gr1_base = ARM_SMMU_GR1(smmu);
>>> @@ -840,11 +1080,16 @@ static void arm_smmu_init_context_bank(struct
>>> arm_smmu_domain *smmu_domain)
>>>       }
>>>
>>>       /* TTBR0 */
>>> -    arm_smmu_flush_pgtable(smmu, cfg->pgd,
>>> -                   PTRS_PER_PGD * sizeof(pgd_t));
>>> -    reg = __pa(cfg->pgd);
>>> +    /* Xen: The page table is shared with the P2M code */
>>> +    ASSERT(smmu_domain->cfg.domain != NULL);
>>> +    p2maddr = page_to_maddr(smmu_domain->cfg.domain->arch.p2m.root);
>>> +
>>> +    dev_notice(smmu->dev, "d%u: p2maddr 0x%"PRIpaddr"\n",
>>> +           smmu_domain->cfg.domain->domain_id, p2maddr);
>>> +
>>> +    reg = (p2maddr & ((1ULL << 32) - 1));
>>>       writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_LO);
>>> -    reg = (phys_addr_t)__pa(cfg->pgd) >> 32;
>>> +    reg = (p2maddr >> 32);
>>>       if (stage1)
>>>           reg |= ARM_SMMU_CB_ASID(cfg) << TTBRn_HI_ASID_SHIFT;
>>>       writel_relaxed(reg, cb_base + ARM_SMMU_CB_TTBR0_HI);
>>
>> Not sure how we could get rid of this change.
>> Maybe we could keep pgd in arm_smmu_cfg and make it point to
>> smmu_domain->cfg.domain->arch.p2m.root?
> 
> Maybe, I will look at it.

I though more about it. __pa(...) requires a virtual address on
parameter. As the page allocated for the P2M is part of the domheap,
there is no permanent mapping.

That would require to map the p2m or override __pa.

IHMO, both of those case a less clear than the current code. So I will
keep the current solution.

Regards,

-- 
Julien Grall