Re: [PATCH v3] xen: arm32: reduce default size of the xenheap

[Julien Grall <julien.grall@linaro.org>]

Hi Ian,

On 19/02/15 17:39, Ian Campbell wrote:
> ... and make it tunable via the command line.
> 
> 1/8 of RAM is 128M on a 1GB system and 256M on a 2GB system etc,
> which is a lot. 1/32 of RAM seems more reasonable. Also drop the
> minimum to 32M.
> 
> Leave the maximum at 1GB.
> 
> Signed-off-by: Ian Campbell <ian.campbell@citrix.com>

Reviewed-by: Julien Grall <julien.grall@linaro.org>

> Cc: Jintack Lim <jintack@cs.columbia.edu>
> Cc: Jan Beulich <JBeulich@suse.com>
> ---
> v3:
>  - Clarify doc and comments
>  - Enforce new minimum of 32M, not old 128M
>  - Only allocate exact amount if user gives a value, rather than
>    searching for the next smallest power of two we can find.
> v2:
>  - Use xenheap_megabytes as the option, which is what older x86 Xen
>    used.
> 
> I'd like to backport at least the command line option to 4.5. Reducing
> the default heap size is a bit border line but I'm inclined to take
> it.

I'm fine with the backport.

Regards,

-- 
Julien Grall