From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
Subject: Re: [PATCH v9 02/14] eal_pci: Add flag to hold kernel
	driver type
Date: Fri, 20 Feb 2015 14:18:34 +0900
Message-ID: <54E6C3AA.6030700@igel.co.jp>
References: <1424060073-23484-12-git-send-email-mukawa@igel.co.jp>
 <1424314187-25177-1-git-send-email-mukawa@igel.co.jp>
 <1424314187-25177-3-git-send-email-mukawa@igel.co.jp>
 <5677937.pUHUTuZF0f@xps13> <54E5E547.2020806@igel.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <54E5E547.2020806-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

On 2015/02/19 22:29, Tetsuya Mukawa wrote:
> On 2015/02/19 20:17, Thomas Monjalon wrote:
>>> @@ -152,6 +159,7 @@ struct rte_pci_device {
>>>  	uint16_t max_vfs;                       /**< sriov enable if not ze=
ro */
>>>  	int numa_node;                          /**< NUMA node connection *=
/
>>>  	struct rte_devargs *devargs;            /**< Device user arguments =
*/
>>> +	enum rte_pt_driver pt_driver;		/**< Driver of passthrough */
>> [...]
>>> +static int
>>> +pci_get_kernel_driver_by_path(const char *filename, char *dri_name)
>> I think "kernel driver" is a good name. Why not using this name in the=

>> pci_device struct to be more consistent?
> Hi Michael,
>
> Could you please let me know what do you think about it?

Hi Thomas,

Could you please check below reply from Michael?
He has already replied it.
http://dpdk.org/dev/patchwork/patch/3363/

According to Tim's email, he might be out of office until middle of next
week.
I cannot rewrite his patch without his agreement. So I will submit
patches without this.
If we decide to change it when he comes back, I will send v11 patches.

Thanks,
Tetsuya

> Thanks
> Tetsuya
>
>> Thanks