* [PATCH 1/2] staging: i2o: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
2015-02-20 1:43 [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Aya Mahfouz
@ 2015-02-20 1:43 ` Aya Mahfouz
2015-02-20 1:44 ` [PATCH 2/2] " Aya Mahfouz
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Aya Mahfouz @ 2015-02-20 1:43 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
drivers/staging/i2o/i2o_config.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/i2o/i2o_config.c b/drivers/staging/i2o/i2o_config.c
index 04bd3b6..5748663 100644
--- a/drivers/staging/i2o/i2o_config.c
+++ b/drivers/staging/i2o/i2o_config.c
@@ -34,8 +34,7 @@
#include <linux/mutex.h>
#include <linux/compat.h>
#include <linux/slab.h>
-
-#include <asm/uaccess.h>
+#include <linux/uaccess.h>
#include "core.h"
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] staging: i2o: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
2015-02-20 1:43 [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Aya Mahfouz
2015-02-20 1:43 ` [PATCH 1/2] staging: i2o: " Aya Mahfouz
@ 2015-02-20 1:44 ` Aya Mahfouz
2015-02-20 7:20 ` [Outreachy kernel] [PATCH 0/2] " Julia Lawall
2015-02-20 7:48 ` Preeti U Murthy
3 siblings, 0 replies; 6+ messages in thread
From: Aya Mahfouz @ 2015-02-20 1:44 UTC (permalink / raw)
To: outreachy-kernel
This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
drivers/staging/i2o/i2o_proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/i2o/i2o_proc.c b/drivers/staging/i2o/i2o_proc.c
index ad84f33..cea536a 100644
--- a/drivers/staging/i2o/i2o_proc.c
+++ b/drivers/staging/i2o/i2o_proc.c
@@ -48,9 +48,9 @@
#include <linux/errno.h>
#include <linux/spinlock.h>
#include <linux/workqueue.h>
+#include <linux/uaccess.h>
#include <asm/io.h>
-#include <asm/uaccess.h>
#include <asm/byteorder.h>
/* Structure used to define /proc entries */
--
1.9.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
2015-02-20 1:43 [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Aya Mahfouz
2015-02-20 1:43 ` [PATCH 1/2] staging: i2o: " Aya Mahfouz
2015-02-20 1:44 ` [PATCH 2/2] " Aya Mahfouz
@ 2015-02-20 7:20 ` Julia Lawall
2015-02-20 7:48 ` Preeti U Murthy
3 siblings, 0 replies; 6+ messages in thread
From: Julia Lawall @ 2015-02-20 7:20 UTC (permalink / raw)
To: Aya Mahfouz; +Cc: outreachy-kernel
On Fri, 20 Feb 2015, Aya Mahfouz wrote:
> This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The
> replacements is safe since the header file <linux/uaccess.h> includes
> <asm/uaccess.h>
Thoughtful comment. Thanks.
julia
> Aya Mahfouz (2):
> staging: i2o: Use #include <linux/uaccess.h> instead of
> <asm/uaccess.h>
> staging: i2o: Use #include <linux/uaccess.h> instead of
> <asm/uaccess.h>
>
> drivers/staging/i2o/i2o_config.c | 3 +--
> drivers/staging/i2o/i2o_proc.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> --
> 1.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1424395309.git.mahfouz.saif.elyazal%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Outreachy kernel] [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
2015-02-20 1:43 [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h> Aya Mahfouz
` (2 preceding siblings ...)
2015-02-20 7:20 ` [Outreachy kernel] [PATCH 0/2] " Julia Lawall
@ 2015-02-20 7:48 ` Preeti U Murthy
2015-02-21 4:30 ` Aya Mahfouz
3 siblings, 1 reply; 6+ messages in thread
From: Preeti U Murthy @ 2015-02-20 7:48 UTC (permalink / raw)
To: Aya Mahfouz, outreachy-kernel
Hi Aya,
On 02/20/2015 07:13 AM, Aya Mahfouz wrote:
> This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The
> replacements is safe since the header file <linux/uaccess.h> includes
> <asm/uaccess.h>
Like Julia mentioned its a thoughtful comment. Such explanations are
encouraged. However, it will be more valuable to include the above
explanation in the changelogs of the patches also since those go into
the git log of the kernel. The cover letter contains an overview of the
patchset to help the reviewers. They do not get documented in the
history of changes to the kernel. Would you therefore be able to resend
this as a fresh version including the above lines in the changelog of
the individual patches?
Regards
Preeti U Murthy
>
> Aya Mahfouz (2):
> staging: i2o: Use #include <linux/uaccess.h> instead of
> <asm/uaccess.h>
> staging: i2o: Use #include <linux/uaccess.h> instead of
> <asm/uaccess.h>
>
> drivers/staging/i2o/i2o_config.c | 3 +--
> drivers/staging/i2o/i2o_proc.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Outreachy kernel] [PATCH 0/2] Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
2015-02-20 7:48 ` Preeti U Murthy
@ 2015-02-21 4:30 ` Aya Mahfouz
0 siblings, 0 replies; 6+ messages in thread
From: Aya Mahfouz @ 2015-02-21 4:30 UTC (permalink / raw)
To: Preeti U Murthy, julia.lawall; +Cc: outreachy-kernel
On Fri, Feb 20, 2015 at 01:18:16PM +0530, Preeti U Murthy wrote:
> Hi Aya,
>
> On 02/20/2015 07:13 AM, Aya Mahfouz wrote:
> > This patchset replaces <asm/uaccess.h> by <linux/uaccess.h>. The
> > replacements is safe since the header file <linux/uaccess.h> includes
> > <asm/uaccess.h>
>
> Like Julia mentioned its a thoughtful comment. Such explanations are
> encouraged. However, it will be more valuable to include the above
> explanation in the changelogs of the patches also since those go into
> the git log of the kernel. The cover letter contains an overview of the
> patchset to help the reviewers. They do not get documented in the
> history of changes to the kernel. Would you therefore be able to resend
> this as a fresh version including the above lines in the changelog of
> the individual patches?
>
> Regards
> Preeti U Murthy
Thank you Julia and Preeti for your comments. I will not send a new
version of this patch since the driver will be out of staging as Julia
stated in another thread. However, I will keep your advice in mind for
future patches.
Kind Regards,
Aya Saif El-yazal Mahfouz
> >
> > Aya Mahfouz (2):
> > staging: i2o: Use #include <linux/uaccess.h> instead of
> > <asm/uaccess.h>
> > staging: i2o: Use #include <linux/uaccess.h> instead of
> > <asm/uaccess.h>
> >
> > drivers/staging/i2o/i2o_config.c | 3 +--
> > drivers/staging/i2o/i2o_proc.c | 2 +-
> > 2 files changed, 2 insertions(+), 3 deletions(-)
> >
>
^ permalink raw reply [flat|nested] 6+ messages in thread