From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [PATCH] dmaengine: qcom_bam_dma: fix wrong register offsets Date: Fri, 20 Feb 2015 14:06:26 +0530 Message-ID: <54E6F20A.60005@codeaurora.org> References: <1424364350-32239-1-git-send-email-svarbanov@mm-sol.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:47928 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751290AbbBTIgd (ORCPT ); Fri, 20 Feb 2015 03:36:33 -0500 In-Reply-To: <1424364350-32239-1-git-send-email-svarbanov@mm-sol.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Stanimir Varbanov , Vinod Koul Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-arm-msm@vger.kernel.org, Andy Gross , Stephen Boyd On 02/19/2015 10:15 PM, Stanimir Varbanov wrote: > The commit fb93f520e (dmaengine: qcom_bam_dma: Generalize BAM > register offset calculations) wrongly populated base offsets > for event registers for bam v1.4. > > Signed-off-by: Stanimir Varbanov > --- > drivers/dma/qcom_bam_dma.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/qcom_bam_dma.c b/drivers/dma/qcom_bam_dma.c > index debe106..95b7668 100644 > --- a/drivers/dma/qcom_bam_dma.c > +++ b/drivers/dma/qcom_bam_dma.c > @@ -162,9 +162,9 @@ static const struct reg_offset_data bam_v1_4_reg_info[] = { > [BAM_P_IRQ_STTS] = { 0x1010, 0x1000, 0x00, 0x00 }, > [BAM_P_IRQ_CLR] = { 0x1014, 0x1000, 0x00, 0x00 }, > [BAM_P_IRQ_EN] = { 0x1018, 0x1000, 0x00, 0x00 }, > - [BAM_P_EVNT_DEST_ADDR] = { 0x102C, 0x00, 0x1000, 0x00 }, > - [BAM_P_EVNT_REG] = { 0x1018, 0x00, 0x1000, 0x00 }, > - [BAM_P_SW_OFSTS] = { 0x1000, 0x00, 0x1000, 0x00 }, > + [BAM_P_EVNT_DEST_ADDR] = { 0x182C, 0x00, 0x1000, 0x00 }, > + [BAM_P_EVNT_REG] = { 0x1818, 0x00, 0x1000, 0x00 }, > + [BAM_P_SW_OFSTS] = { 0x1800, 0x00, 0x1000, 0x00 }, > [BAM_P_DATA_FIFO_ADDR] = { 0x1824, 0x00, 0x1000, 0x00 }, > [BAM_P_DESC_FIFO_ADDR] = { 0x181C, 0x00, 0x1000, 0x00 }, > [BAM_P_EVNT_GEN_TRSHLD] = { 0x1828, 0x00, 0x1000, 0x00 }, > Didn't know how this crept in. Apologies for the inconvenience! Reviewed-by: Archit Taneja -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project