Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Remove brake statement

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/19/15 17:13, Ksenija Stanojevic wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: "break is not useful after a goto or return"
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/r819xU_phy.c | 1 -
>  1 file changed, 1 deletion(-)

Patch looks good - your patch description works, so this is in the minor
section.

However, in general I recommend writing a message rather than relying on
automated output from checkpatch. You can note in the message that the
issue was found by checkpatch if you like. Something like this:

"Remove meaningless break after return in switch statement. This was
found by checkpatch.pl."

Cheers,
Jes


> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
> index dbd3321..d006602 100644
> --- a/drivers/staging/rtl8192u/r819xU_phy.c
> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
> @@ -1344,7 +1344,6 @@ static u8 rtl8192_phy_SwChnlStepByStep(struct net_device *dev, u8 channel,
>  	default:
>  		RT_TRACE(COMP_ERR, "Unknown RFChipID: %d\n", priv->rf_chip);
>  		return true;
> -		break;
>  	}
>  
>  
>