From: Jes Sorensen <jes.sorensen@gmail.com>
To: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Remove space before tab
Date: Fri, 20 Feb 2015 06:32:13 -0500 [thread overview]
Message-ID: <54E71B3D.6090107@gmail.com> (raw)
In-Reply-To: <1424383520-21750-1-git-send-email-ksenija.stanojevic@gmail.com>
On 02/19/15 17:05, Ksenija Stanojevic wrote:
> This patch fixes the checkpatch.pl warning:
> WARNING: "please, no space before tabs"
>
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> drivers/staging/rtl8192u/r819xU_phy.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Again here your patch looks fine, the only thing needed to make it top
of the line is a more personalized commit message.
Cheers,
Jes
> diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
> index 0589602..dbd3321 100644
> --- a/drivers/staging/rtl8192u/r819xU_phy.c
> +++ b/drivers/staging/rtl8192u/r819xU_phy.c
> @@ -106,10 +106,10 @@ void rtl8192_setBBreg(struct net_device *dev, u32 reg_addr, u32 bitmask,
> /******************************************************************************
> * function: This function reads specific bits from BB register
> * input: net_device *dev
> - * u32 reg_addr //target addr to be readback
> - * u32 bitmask //taget bit pos to be readback
> + * u32 reg_addr //target addr to be readback
> + * u32 bitmask //taget bit pos to be readback
> * output: none
> - * return: u32 data //the readback register value
> + * return: u32 data //the readback register value
> * notice:
> ******************************************************************************/
> u32 rtl8192_QueryBBReg(struct net_device *dev, u32 reg_addr, u32 bitmask)
> @@ -478,7 +478,7 @@ static void phy_FwRFSerialWrite(struct net_device *dev,
> /******************************************************************************
> * function: This function reads BB parameters from header file we generate,
> * and do register read/write
> - * input: net_device *dev
> + * input: net_device *dev
> * output: none
> * return: none
> * notice: BB parameters may change all the time, so please make
>
next prev parent reply other threads:[~2015-02-20 11:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 22:05 [PATCH] Staging: rtl8192u: Remove space before tab Ksenija Stanojevic
2015-02-20 11:32 ` Jes Sorensen [this message]
[not found] ` <1424432471809.1839906750@boxbe>
2015-02-20 12:18 ` [Outreachy kernel] [PATCH] Staging: rtl8192u: Remove space beforetab Ksenija Stanojević
2015-02-20 14:30 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E71B3D.6090107@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=ksenija.stanojevic@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.