From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC] [PATCH 3/3] XEN ARM PCI support Date: Fri, 20 Feb 2015 12:12:54 +0000 Message-ID: <54E724C6.1020000@linaro.org> References: <54E71EEF.30506@caviumnetworks.com> <54E72E620200007800061F4A@mail.emea.novell.com> <54E722ED.50807@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54E722ED.50807@caviumnetworks.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org, Jan Beulich , Ian Campbell , Stefano Stabellini , Vijay Kilari List-Id: xen-devel@lists.xenproject.org On 20/02/15 12:05, Manish Jaggi wrote: > On 20/02/15 5:23 pm, Jan Beulich wrote: >> All of these #ifdef-s call for better abstraction. And in no case is it >> acceptable to replace blank lines with #ifdef-s like you do. > Good observation. I will take care for the blank lines. > A lot of code existed in generic files specific to x86, so arm specific > defines. Some of us have filter to get quickly mail where we are CCed. So please reply to all rather than only the mailing list. Thanks, -- Julien Grall