Re: RFC: [PATCH 1/3] Enhance platform support for PCI

[Manish Jaggi <mjaggi@caviumnetworks.com>]

On 20/02/15 6:04 pm, Manish Jaggi wrote:
>
> On 20/02/15 5:50 pm, Julien Grall wrote:
>> On 20/02/15 12:10, Manish Jaggi wrote:
>>> On 20/02/15 5:33 pm, Julien Grall wrote:
>>>> Hello Manish,
>>>>
>>>> On 20/02/15 11:34, Manish Jaggi wrote:
>>>>> The platform APIs are enhanced to provide support for parsing pci 
>>>>> device
>>>>> tree nodes and storing the config-space address which is later 
>>>>> used for
>>>>> pci_read/pci_write config calls.
>>>> Can you explain why you choose to add per-platform callbacks rather 
>>>> than
>>>> a generic solution?
>>> The platform code is similar to what linux has in
>>> drivers/pci/host/pci-<platform>.c. I have used the same concept.
>> Please explain it in the commit message, it helps us to understand why
>> you did it.
>>
>> Anyway, based on what you said, your approach looks wrong.
> ok :)
>> Firstly, the platform code is DT-centric and we don't expect to have a
>> such things for ACPI.
>>
>> Secondly, the PCI host code be shared between multiple platform.
>>
>> Overall, I would prefer to have a separate file and structure for
>> handling PCI host. Also, I think we could re-use the Linux code for this
>> purpose.
> I will move the code to drivers/pci/host
I have added ABI that segment no maps to the position on pci node in xen 
device tree. We had partially discussed about this during Linaro 
connect. What is your teams view on this, should this be ok or we 
introduce a property in device tree pci node {xen_segment_id = <1>}
>> Regards,
>>
>