From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH v3 10/13] xen/iommu: smmu: Check for
 duplicate stream IDs when registering master devices
Date: Fri, 20 Feb 2015 13:34:16 +0000
Message-ID: <54E737D8.2020700@linaro.org>
References: <1422643768-23614-1-git-send-email-julien.grall@linaro.org>	
	<1422643768-23614-11-git-send-email-julien.grall@linaro.org>
	<1424435723.30924.212.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <julien.grall@linaro.org>) id 1YOnjF-0008Ma-6d
	for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 13:34:49 +0000
Received: by wesw55 with SMTP id w55so5677174wes.4
	for <xen-devel@lists.xenproject.org>;
	Fri, 20 Feb 2015 05:34:43 -0800 (PST)
In-Reply-To: <1424435723.30924.212.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>
Cc: Andreas Herrmann <andreas.herrmann@calxeda.com>, xen-devel@lists.xenproject.org, Andreas Herrmann <herrmann.der.user@googlemail.com>, tim@xen.org, stefano.stabellini@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 20/02/15 12:35, Ian Campbell wrote:
> On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote:
>> From: Andreas Herrmann <andreas.herrmann@calxeda.com>
>>
>> If DT information lists one stream ID twice for the master devices of
>> an SMMU this can cause a multi match when stream ID matching is used.
>> For stream ID indexing this might trigger an overwrite of an S2CR that
>> is already in use.
>>
>> So better check for duplicates when DT information is parsed.
>>
>> Taken from the linux ML:
>> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-January/226099.html
>>
>> Cc: Andreas Herrmann <herrmann.der.user@googlemail.com>
>> Signed-off-by: Andreas Herrmann <andreas.herrmann@calxeda.com>
>> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> 
> I think you were going to drop this one as it is not strictly required?
> 
> I'm still not entirely clear on the motivation for this patch, looking
> at the v2 thread I see "But, the developer made have written by mistake
> twice the streamid for the device." which I think you were saying that
> the DT might, hypothetically, be wrong and have duplicated IDs, is that
> right?
> 
> Is it a hypothetical problem or have we seen it in a real device-tree?

It's an hypothetical problem. The algo on the next patch won't work
correctly otherwise.

I may need to rework a bit the next patch if we drop it.

Regards,

-- 
Julien Grall