From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Ostrovsky Subject: Re: [PATCH v18 14/16] x86/VPMU: NMI-based VPMU support Date: Fri, 20 Feb 2015 11:24:34 -0500 Message-ID: <54E75FC2.9020506@oracle.com> References: <1424125619-10851-1-git-send-email-boris.ostrovsky@oracle.com> <1424125619-10851-15-git-send-email-boris.ostrovsky@oracle.com> <54E75AD6020000780006218A@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54E75AD6020000780006218A@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: kevin.tian@intel.com, suravee.suthikulpanit@amd.com, andrew.cooper3@citrix.com, tim@xen.org, dietmar.hahn@ts.fujitsu.com, xen-devel@lists.xen.org, Aravind.Gopalakrishnan@amd.com, jun.nakajima@intel.com, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org On 02/20/2015 10:03 AM, Jan Beulich wrote: >>>> On 16.02.15 at 23:26, wrote: >> +int pmu_nmi_interrupt(const struct cpu_user_regs *regs, int cpu) > static > >> +{ >> + return vpmu_do_interrupt(regs); > That function returning 1 makes do_nmi() not do _anything_ else, i.e. > ignore eventual SERR or IOCHK events. That's not acceptable. I guess > you'll need to make nmi_callback() return values tristate and adjust > do_nmi() to deal with both cases. Albeit - the other two users are > breaking this too, so perhaps do_nmi() should be adjusted in a prereq > (and backportable) patch to not bail in that case. Yet a tristate may > still be needed, since alternative_instructions() legitimately wants to > suppress them getting handled - it would just need to invoke their > handling once done with patching. I think I will separate this patch from the series then and submit it later. -boris