Re: [Outreachy kernel] [PATCH 11/11] Staging: drivers: usb: serial: ipw: Deleted space

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 11:56, Hatice ERTÜRK wrote:
> Deleted spaces in 263 line.
> Used the checkpatch.pl.
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/usb/serial/ipw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

It would be better to describe this as 'Deleted spaces mixed into tab
indentation'.

In addition, when you post a set of patches, you should post them as one
set, rather than individual emails. Using a cover letter for the whole
set is recommended.

Cheers,
Jes


> diff --git a/drivers/usb/serial/ipw.c b/drivers/usb/serial/ipw.c
> index 8b1cf18..150bca9 100644
> --- a/drivers/usb/serial/ipw.c
> +++ b/drivers/usb/serial/ipw.c
> @@ -260,7 +260,7 @@ static void ipw_close(struct usb_serial_port *port)
>  	dev_dbg(dev, "%s:sending purge\n", __func__);
>  	result = usb_control_msg(udev, usb_sndctrlpipe(udev, 0),
>  			 IPW_SIO_PURGE, USB_TYPE_VENDOR |
> -			 		USB_RECIP_INTERFACE | USB_DIR_OUT,
> +					USB_RECIP_INTERFACE | USB_DIR_OUT,
>  			 0x03,
>  			 0,
>  			 NULL,
>