All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Benjamin LaHaise <bcrl@kvack.org>
Cc: Mike Galbraith <umgwanakikbuti@gmail.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	<linux-rt-users@vger.kernel.org>,
	Kent Overstreet <kmo@daterainc.com>
Subject: Re: [PATCH-rt 0/2] Fix up aio splats at reboot garbage collection
Date: Fri, 20 Feb 2015 12:46:48 -0500	[thread overview]
Message-ID: <54E77308.5080904@windriver.com> (raw)
In-Reply-To: <20150220173929.GJ26974@kvack.org>

On 2015-02-20 12:39 PM, Benjamin LaHaise wrote:
> On Fri, Feb 20, 2015 at 12:31:17PM -0500, Paul Gortmaker wrote:
>> On 2015-02-18 08:33 AM, Mike Galbraith wrote:
>>> On Wed, 2015-02-18 at 12:28 +0100, Sebastian Andrzej Siewior wrote:
>>>> * Paul Gortmaker | 2015-02-15 15:52:37 [-0500]:
>>>>
>>>>> We ran into a splat during reboot that was caused by the percpu_ref_kill
>>>>> garbage collection in the fs/aio code.
>>>>
>>>> Could you please check if
>>>>      https://lkml.org/lkml/2015/2/16/391
>>>> works for you?
>>>
>>> I did not see a gripe with that and ltp.
>>
>> Same here ; set aside my two commits and applied the
>> sworkqueue implementation and the proposed aio patch
>> to the 3.14-rt tree and it doesn't splat on reboot.
>
> Sebastian, is this safe for non-RT kernels?  If so, could you please resend
> against mainline with a Signed-off-by so we can get this properly fixed?

The simple waitqueue and simple workqueue are -rt specific
additions; while we probably want to get those mainline
since they bring size optimizations, they aren't in there
yet, so we can't use this in mainline yet.

P.
--

>
> 		-ben
>
>> Thanks,
>> Paul.
>> --
>>
>>>
>>> 	-Mike
>>>
>


      reply	other threads:[~2015-02-20 17:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-15 20:52 [PATCH-rt 0/2] Fix up aio splats at reboot garbage collection Paul Gortmaker
2015-02-15 20:52 ` [PATCH-rt 1/2] aio: don't take the ctx_lock during rcu garbage collection at reboot Paul Gortmaker
2015-02-15 23:50   ` Benjamin LaHaise
2015-02-15 20:52 ` [PATCH-rt 2/2] aio: fix splat in free_ioctx_reqs by using percpu callback Paul Gortmaker
2015-02-18 11:28 ` [PATCH-rt 0/2] Fix up aio splats at reboot garbage collection Sebastian Andrzej Siewior
2015-02-18 13:33   ` Mike Galbraith
2015-02-20 17:31     ` Paul Gortmaker
2015-02-20 17:39       ` Benjamin LaHaise
2015-02-20 17:46         ` Paul Gortmaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E77308.5080904@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=bcrl@kvack.org \
    --cc=bigeasy@linutronix.de \
    --cc=kmo@daterainc.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.