From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 17/24] xen/passthrough: arm: release earlier the DT devices assigned to a guest Date: Fri, 20 Feb 2015 17:46:53 +0000 Message-ID: <54E7730D.4020009@linaro.org> References: <1421159133-31526-1-git-send-email-julien.grall@linaro.org> <1421159133-31526-18-git-send-email-julien.grall@linaro.org> <1424451784.30924.362.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YOrfd-0007tv-Q5 for xen-devel@lists.xenproject.org; Fri, 20 Feb 2015 17:47:21 +0000 Received: by wesq59 with SMTP id q59so7023179wes.1 for ; Fri, 20 Feb 2015 09:47:20 -0800 (PST) In-Reply-To: <1424451784.30924.362.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 20/02/15 17:03, Ian Campbell wrote: > On Tue, 2015-01-13 at 14:25 +0000, Julien Grall wrote: > > Subject: "release the DT devices assigned to a guest earlier" > >> The toolstack may not have deassign every device used by a guest. > > "deassigned" > >> Therefore we have to go through the device list and removing them before > > "and remove them" > >> asking the IOMMU drivers to release memory for this domain. >> >> This can be done by moving the call to the release function when we >> relinquish the resources. The IOMMU part will be destroyed later when >> the domain is freed. >> >> Signed-off-by: Julien Grall >> Cc: Jan Beulich > > Acked-by: Ian Campbell > > I'd like to hear Jan's opinion though. FWIW, this is how it's done for PCI. Regards, -- Julien Grall