All of lore.kernel.org
 help / color / mirror / Atom feed
From: axboe@kernel.dk (Jens Axboe)
Subject: [PATCH] NVME: Splitting large i/o in the ioctl path
Date: Fri, 20 Feb 2015 10:34:31 -0800	[thread overview]
Message-ID: <54E77E37.9020808@kernel.dk> (raw)
In-Reply-To: <alpine.LNX.2.00.1502201822420.32385@localhost.lm.intel.com>

On 02/20/2015 10:31 AM, Keith Busch wrote:
> On Fri, 20 Feb 2015, Sathayavathi M wrote:
>> +    else
>> +        dev->max_hw_sectors = BLK_DEF_MAX_SECOTRS;
>
> I think you meant BLK_DEF_MAX_SECTORS. Sometimes I submit patches that
> don't compile either. :)

Coincidentally, that define has been removed recently...

> Anyway, I think we need to fix the driver's adding disks of this extended
> type first. Right now I think we're corrupting data and memory if we
> encounter such a device. I proposed setting the capacity to 0 so you
> can still access the disk media through the ioctl, but not through the
> standard block layer.

Agree.

-- 
Jens Axboe

  reply	other threads:[~2015-02-20 18:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  8:44 [PATCH] NVME: Splitting large i/o in the ioctl path Sathayavathi M
2015-02-20 18:31 ` Keith Busch
2015-02-20 18:34   ` Jens Axboe [this message]
     [not found] <1648698662.233191424693005310.JavaMail.weblogic@epmlwas07b>
2015-02-23 22:28 ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54E77E37.9020808@kernel.dk \
    --to=axboe@kernel.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.