From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
netdev@vger.kernel.org, "Jan \"Yenya\" Kasprzak" <kas@fi.muni.cz>
Subject: Re: [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state()
Date: Fri, 20 Feb 2015 22:15:03 +0300 [thread overview]
Message-ID: <54E787B7.5000609@cogentembedded.com> (raw)
In-Reply-To: <1849761882.58117.1424458263796.open-xchange@webmail.nmp.proximus.be>
On 02/20/2015 09:51 PM, Fabian Frederick wrote:
>>> Use helper functions to access current->state.
>>> Direct assignments are prone to races and therefore buggy.
>>> current->state = TASK_RUNNING is replaced by __set_current_state()
>> You sometimes use __set_current_state() and sometimes set_current_state().
> Hello Sergei,
> Peter suggested to use __set_current_state() for TASK_RUNNING :
> http://marc.info/?l=linux-kernel&m=142442259719216&w=2
I didn't even question your decisions, I (like Peter) just wanted a more
coherent change-log. Thanks to Peter for the explanations though. :-)
> Regards,
> Fabian
>>> Thanks to Peter Zijlstra for the exact definition of the problem.
>>> Suggested-By: Peter Zijlstra <peterz@infradead.org>
>>> Signed-off-by: Fabian Frederick <fabf@skynet.be>
>> [...]
WBR, Sergei
next prev parent reply other threads:[~2015-02-20 19:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 18:12 [PATCH 1/7 linux-next] swim: replace current->state by set_current_state() Fabian Frederick
2015-02-20 18:12 ` [PATCH 2/7 linux-next] mISDN: " Fabian Frederick
2015-02-22 20:24 ` David Miller
2015-02-20 18:12 ` [PATCH 3/7 linux-next] powerpc/pmac: " Fabian Frederick
2015-02-20 18:12 ` Fabian Frederick
2015-02-20 18:12 ` [PATCH 4/7 linux-next] saa7146: " Fabian Frederick
2015-02-20 18:12 ` [PATCH 5/7 linux-next] hso: replace current->state by __set_current_state() Fabian Frederick
2015-02-22 20:25 ` David Miller
2015-02-20 18:12 ` [PATCH 6/7 linux-next] wan: cosa: replace current->state by set_current_state() Fabian Frederick
2015-02-20 18:26 ` Jan Yenya Kasprzak
2015-02-20 18:34 ` Sergei Shtylyov
2015-02-20 18:51 ` Fabian Frederick
2015-02-20 19:15 ` Sergei Shtylyov [this message]
2015-02-20 18:58 ` Peter Zijlstra
2015-02-20 19:31 ` Eric Dumazet
2015-02-20 19:44 ` Eric Dumazet
2015-02-20 20:02 ` Peter Zijlstra
2015-02-21 7:42 ` Fabian Frederick
2015-02-22 20:25 ` David Miller
2015-02-20 18:12 ` [PATCH 7/7 linux-next] serial: core: replace current->state by __set_current_state() Fabian Frederick
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E787B7.5000609@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=fabf@skynet.be \
--cc=gregkh@linuxfoundation.org \
--cc=kas@fi.muni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.