From: Andy Lutomirski <luto@amacapital.net>
To: Bastien Nocera <hadess@hadess.net>,
Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys
Date: Fri, 20 Feb 2015 11:27:39 -0800 [thread overview]
Message-ID: <54E78AAB.2020604@mit.edu> (raw)
In-Reply-To: <1424443477.22910.18.camel@hadess.net>
On 02/20/2015 06:44 AM, Bastien Nocera wrote:
> + KEY_MICCANCEL_MODE, /* Microphone cancellation */
What's this? We already have KEY_MICMUTE. Is this different? If so,
can you improve the comment a bit?
The answer may be obvious to anyone who has an awful X1 carbon gen 2
keyboard, but these KEY_XYZ defines should IMO be clear enough that even
people without the hardware can figure out what's going on.
--Andy
next prev parent reply other threads:[~2015-02-20 19:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-20 14:44 [PATCH 6/7] thinkpad_acpi: More Carbon X1 2014 keys Bastien Nocera
2015-02-20 19:27 ` Andy Lutomirski [this message]
2015-02-23 10:09 ` Bastien Nocera
2015-02-23 15:51 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E78AAB.2020604@mit.edu \
--to=luto@amacapital.net \
--cc=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=ibm-acpi@hmh.eng.br \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.