Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: ieee80211: Replace <asm/string.h> with <linux/string.h>

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 14:32, Ksenija Stanojevic wrote:
> This patch fixes the following checkpatch.pl warning:
> Use #include <linux/string.h> instead of <asm/string.h>
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index 5533221..80dfa07 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -15,7 +15,7 @@
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> -#include <asm/string.h>
> +#include <linux/string.h>
>  #include <asm/errno.h>
>  
>  #include "ieee80211.h"
> 

I just noticed you were generating two patches for very similar changes
errno.h and string.h. Since these changes are to the same file and
basically identical changes, doing them both in one patch is preferred.

Cheers,
Jes