Re: [Outreachy kernel] [PATCH] Staging: lustre: Remove unnecessary else after return

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/20/15 16:05, aybuke ozdemir wrote:
> This patch fixes "else is not generally useful after
> a break or return" checkpatch.pl warning using goto statement in lcommon_cl.c
> 
> Signed-off-by: aybuke ozdemir <aybuke.147@gmail.com>
> ---
>  drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Looks good to me.

Jes


> diff --git a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> index 23095bb..b8311c6 100644
> --- a/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> +++ b/drivers/staging/lustre/lustre/lclient/lcommon_cl.c
> @@ -834,7 +834,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
>  				    size_index < cur_index)
>  					*exceed = 1;
>  			}
> -			return result;
> +			goto out;
>  		} else {
>  			/*
>  			 * region is within kms and, hence, within real file
> @@ -857,6 +857,7 @@ int ccc_prep_size(const struct lu_env *env, struct cl_object *obj,
>  		}
>  	}
>  	ccc_object_size_unlock(obj);
> +out:
>  	return result;
>  }
>  
>