From: Sean V Kelley <seanvk@posteo.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] drm/i915: Do not invalidate obj->pages under mempressure
Date: Fri, 20 Feb 2015 14:19:49 -0800 [thread overview]
Message-ID: <54E7B305.8090201@posteo.de> (raw)
In-Reply-To: <CAKMK7uHoijOsuzWRmo1UDcozmUcNxN56RrQPTn8x+xZPtQS68A@mail.gmail.com>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 02/11/2015 05:02 AM, Daniel Vetter wrote:
> On Wed, Feb 11, 2015 at 1:55 AM, Sean V Kelley <seanvk@posteo.de>
> wrote:
>> No corruption seen. I will add reloc domains to my growing audit
>> list.
>
> One more for the libva audit list:
>
> If you do any ioctl directly, please make sure that you clear the
> ioctl structure with memset(&arg, 0, sizeof(arg)); or similar.
> Otherwise when we extended them in upstream (which we're just
> doing, the kernel 0-fills the new fields automatically) it'll break
> because after a recompile there's now garbage in the new fields.
>
> I just spent a while fixing up libdrm ;-) -Daniel
>
Cleaned up the hybrid driver. Found numerous instances of the
wrong reloc domain assignments, e.g., write_domain of 0. I've since
verified it was the root cause of the run 2 run issue. Also cleaned up
ioctl and structure clearing.
Thanks,
Sean
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJU57L/AAoJEGScDsMo8QYOFsIQANHSmmYUG5JSqsmewCDO1zHk
dh2h56x5oCIooJ2mOh9lcWTRpVbE4uv6HOt6WfThb4dP11Yg5LlOZA1uR65iniIy
9gi2vUotuajm9cOdXKVXCbQBuymR0rKJuRb74e73jk/u5QpOv/zNtThXOG7FfUVu
p1DpoVuh8iLGexwAd+6UrCOze5hWfCuh+9t9jTZ8Yr0pgSiRsGClX1mW8vUD4+99
7h5VGonr3tKYqHNZBtneaTcmRkVBtuZ/RBGr5FOnzP1VKIXidgt2t4ID33nZmjsx
rJjzQfh408qniBr9L7zIIDUZMiiAucIRm1+4eQ1b+yA9pYkXQfrs/lA9dH80IjAw
iWFS+IX7xUCpKZzLB38+dIV/Nsn0nxoF5N1ptz4RMKoeXJVWsRS72jgCjlrE5w4R
dnyodU7nlmdcNoeGcDEhcN5Jek7OPYoJLgaC100wu6yDZKJ/2CXJ6XwyORWQ7GU1
UWyqOuam84DJqiwzwkLl6Q9Ur7oC8S8jUIFLqRk/1PZOesu90/yNoJUByLQMMZbl
WzUMGdV4D18+uTHhmWGPruCYHLMgRXKVlT/diKH1q5aBOvtP4xeANn+0GSw+E3OZ
TN1TGDW/q8U0uN1CDk5hTIDgiJX0Eo9an0CsJ2yZL3K+J56+e6QUY6EPrU/ctqp0
QbT5eI44/dZX2Xmf/kc7
=24vy
-----END PGP SIGNATURE-----
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-02-20 22:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 20:34 [PATCH] drm/i915: Do not invalidate obj->pages under mempressure Chris Wilson
2015-01-15 0:55 ` [Intel-gfx] " Daniel Vetter
2015-01-15 1:19 ` Sean V Kelley
2015-01-15 9:38 ` Chris Wilson
2015-01-15 2:11 ` shuang.he
2015-01-15 19:36 ` Daniel Vetter
2015-01-15 20:44 ` [Intel-gfx] " Chris Wilson
2015-01-17 4:05 ` Daniel Vetter
2015-02-08 23:27 ` [Intel-gfx] " Sean V Kelley
2015-02-09 16:46 ` Chris Wilson
2015-02-09 18:31 ` Sean V Kelley
2015-02-11 0:55 ` Sean V Kelley
2015-02-11 13:02 ` Daniel Vetter
2015-02-20 22:19 ` Sean V Kelley [this message]
2015-02-09 16:43 ` Daniel Vetter
2015-02-10 8:19 ` shuang.he
2015-02-10 11:38 ` Jani Nikula
2015-02-24 13:27 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E7B305.8090201@posteo.de \
--to=seanvk@posteo.de \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.