From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YP44H-000761-5f for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:01:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YP44D-0005YY-Oo for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:01:37 -0500 Received: from mail-db3on0087.outbound.protection.outlook.com ([157.55.234.87]:48387 helo=emea01-db3-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YP44D-0005S9-Fz for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:01:33 -0500 Message-ID: <54E801C7.7000803@ezchip.com> Date: Fri, 20 Feb 2015 22:55:51 -0500 From: Chris Metcalf MIME-Version: 1.0 References: <54E67966.1070208@sunrus.com.cn> <54E67AAE.9060507@sunrus.com.cn> In-Reply-To: <54E67AAE.9060507@sunrus.com.cn> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chen Gang S , Peter Maydell , Riku Voipio , "rth@twiddle.net" , "walt@tilera.com" Cc: qemu-devel On 2/19/2015 7:07 PM, Chen Gang S wrote: > +#ifdef TARGET_NR_chown /* not on tilegx */ I would omit all these comments. The same will be true for arm64, microblaze, or any other kernel architecture submitted after the tile architecture went in. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com