From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34884) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YP4Ct-0001lZ-15 for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YP4Cp-0008V7-Oj for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:10:30 -0500 Received: from out1134-178.mail.aliyun.com ([42.120.134.178]:58590) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YP4Cp-0008Uz-BX for qemu-devel@nongnu.org; Sat, 21 Feb 2015 02:10:27 -0500 Message-ID: <54E83134.9010904@sunrus.com.cn> Date: Sat, 21 Feb 2015 15:18:12 +0800 From: Chen Gang S MIME-Version: 1.0 References: <54E67966.1070208@sunrus.com.cn> <54E67AAE.9060507@sunrus.com.cn> <54E801C7.7000803@ezchip.com> In-Reply-To: <54E801C7.7000803@ezchip.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Metcalf , Peter Maydell , Riku Voipio , "rth@twiddle.net" , "walt@tilera.com" Cc: qemu-devel On 2/21/15 11:55, Chris Metcalf wrote: > On 2/19/2015 7:07 PM, Chen Gang S wrote: >> +#ifdef TARGET_NR_chown /* not on tilegx */ > > I would omit all these comments. The same will be true for arm64, microblaze, or any other kernel architecture submitted after the tile architecture went in. > OK, if no any additional reply within 2 days, I shall send patch v4. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed