From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sun, 22 Feb 2015 17:33:16 +0000 Subject: Re: [lm-sensors] i8k: move driver from char to hwmon Message-Id: <54EA12DC.1000403@roeck-us.net> List-Id: References: <201502221250.49466@pali> In-Reply-To: <201502221250.49466@pali> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Arnd Bergmann , Greg Kroah-Hartman , Steven Honeyman , Jean Delvare , Valdis.Kletnieks@vt.edu, Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org T24gMDIvMjIvMjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gSGVsbG8sCj4KPiBj dXJyZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIs Cj4gYmF0dGVyeSwgaG90a2V5cywgdGVtcGVyYXR1cmUgYW5kIGZhbiBjb250cm9sKSBzdXBwb3J0 cyB0d28KPiBpbnRlcmZhY2VzOgo+Cj4gMSkgb2xkIC9wcm9jL2k4ayBjaGFyIGRldmljZQo+IDIp IG5ldyBod21vbiBpbnRlcmZhY2UKPgo+IERyaXZlciBub3cgbGl2ZXMgaW4gY2hhciBzdWJzeXN0 ZW0sIGJ1dCBub3dhZGF5cyBJIHRoaW5rIGxvdCBvZgo+IHBlb3BsZSBhcmUgaW50ZXJlc3RlZCBv bmx5IGluIGh3bW9uIGludGVyZmFjZSB3aGljaCBwcm92aWRlcwo+IHRlbXBlcmF0dXJlICYgZmFu IGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kIGhvdGtleXMgc3VwcG9ydAo+ICh3aGljaCBp cyBtaXNzaW5nIGluIDIpIGJ1dCBwcm92aWRlZCBieSAxKSkgaXMgYWxyZWFkeSBoYW5kbGVkIGJ5 Cj4gQUNQSSBvciBpbnB1dCBzdWJzeXN0ZW0gZm9yIG5ldyBsYXB0b3BzLgo+Cj4gQWxzbyBuYW1l ICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZlIHdoYXQgaXQgbWVhbnMgYW5kCj4gc3VwcG9y dHMuLi4gKEkgd2FzIHRvbGQgaXQgaXMgYWJicmV2aWF0aW9uIGZvciBJbnNwaXJpb24gODAwMAo+ IG1vZGVsIHdoaWNoIHdhcyBwcm9iYWJseSBmaXJzdCBkZWxsIG1vZGVsIHN1cHBvcnRlZCBieSB0 aGF0Cj4gREVMTERJQUcgaW50ZXJmYWNlKS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3Rybywg TGF0aXR1ZGUgYW5kCj4gYWxzbyBQcmVjaXNpb24gYW5kIFhQUyBtb2RlbHMuIEkgdGhpbmsgYXQg bGVhc3QgImRlbGwiIHNob3VsZCBiZQo+IHBhcnQgb2YgZHJpdmVyIG5hbWUgYW5kIGNvbmZpZyBv cHRpb24uCj4KPiBTbyBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Cj4gMSkgTW92ZSBk cml2ZXIgZnJvbSBjaGFyIHN1YnN5c3RlbSB0byBod21vbgo+CkkgYW0gb2sgd2l0aCB0aGlzIG9u ZS4KCj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh ZyBvciBkZWxsc21tCj4KTWlnaHQgYmUgcHJvYmxlbWF0aWMsIGFzIGl0IHdvdWxkIGJyZWFrIGV4 aXN0aW5nIGNvbmZpZ3VyYXRpb25zCnVubGVzcyB5b3Uga2VlcCB0aGUgQ09ORklHX0k4SyBidXQg cmVuYW1lIHRoZSBkcml2ZXIuIERyaXZlciBuYW1lcwphcmUgbmV2ZXIgcGVyZmVjdCwgc28gSSB3 b3VsZCBqdXN0IGxlYXZlIGl0IGFzIGlzLgoKPiAzKSBBZGQgbmV3IENPTkZJR18gb3B0aW9uIHRv IGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UgYW5kCj4gY29tcGlsZSBvbmx5IGh3bW9u IGludGVyZmFjZSBzdXBwb3J0CgpNYWtlcyBzZW5zZS4gSSB3b3VsZCBzdWdnZXN0IHRvIG1ha2Ug aHdtb24gc3VwcHBvcnQgdGhlIGRlZmF1bHQKYW5kIG1hbmRhdG9yeSBpZiB0aGUgZHJpdmVyIGlz IGVuYWJsZWQgYW5kIGFkZCBhIG5ldyBDT05GSUdfSThLX1BST0NJRgpvciBzaW1pbGFyIHdoaWNo IHNob3VsZCBiZSBlbmFibGVkIGJ5IGRlZmF1bHQuCgpBcmUgeW91IGludGVyZXN0ZWQgaW4gYWRk aW5nIHlvdXJzZWxmIGFzIG1haW50YWluZXIgZm9yIHRoaXMgZHJpdmVyID8KClRoYW5rcywKR3Vl bnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxt LXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNvcnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xp c3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlzdGluZm8vbG0tc2Vuc29ycw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752157AbbBVReL (ORCPT ); Sun, 22 Feb 2015 12:34:11 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:34981 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752020AbbBVReJ (ORCPT ); Sun, 22 Feb 2015 12:34:09 -0500 Message-ID: <54EA12DC.1000403@roeck-us.net> Date: Sun, 22 Feb 2015 09:33:16 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= , Arnd Bergmann , Greg Kroah-Hartman , Steven Honeyman , Jean Delvare , Valdis.Kletnieks@vt.edu, Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: i8k: move driver from char to hwmon References: <201502221250.49466@pali> In-Reply-To: <201502221250.49466@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.54EA1310.0074,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2015 03:50 AM, Pali Rohár wrote: > Hello, > > currently i8k driver for DELLDIAG SMM operations (charger, > battery, hotkeys, temperature and fan control) supports two > interfaces: > > 1) old /proc/i8k char device > 2) new hwmon interface > > Driver now lives in char subsystem, but nowadays I think lot of > people are interested only in hwmon interface which provides > temperature & fan control. Power management and hotkeys support > (which is missing in 2) but provided by 1)) is already handled by > ACPI or input subsystem for new laptops. > > Also name "i8k" is really non intuitive what it means and > supports... (I was told it is abbreviation for Inspirion 8000 > model which was probably first dell model supported by that > DELLDIAG interface). Now driver is used on Vostro, Latitude and > also Precision and XPS models. I think at least "dell" should be > part of driver name and config option. > > So I have idea for some changes: > > 1) Move driver from char subsystem to hwmon > I am ok with this one. > 2) Rename driver from i8k to something like delldiag or dellsmm > Might be problematic, as it would break existing configurations unless you keep the CONFIG_I8K but rename the driver. Driver names are never perfect, so I would just leave it as is. > 3) Add new CONFIG_ option to enable/disable /proc/i8k device and > compile only hwmon interface support Makes sense. I would suggest to make hwmon suppport the default and mandatory if the driver is enabled and add a new CONFIG_I8K_PROCIF or similar which should be enabled by default. Are you interested in adding yourself as maintainer for this driver ? Thanks, Guenter