diff for duplicates of <54EA17F4.8000106@roeck-us.net> diff --git a/a/1.txt b/N1/1.txt index 27a3e37..922d1e5 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,41 +1,60 @@ -T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy -IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMDIvMjIv -MjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4+PiBIZWxsbywKPj4+Cj4+PiBjdXJy -ZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIsCj4+ -PiBiYXR0ZXJ5LCBob3RrZXlzLCB0ZW1wZXJhdHVyZSBhbmQgZmFuIGNvbnRyb2wpIHN1cHBvcnRz -IHR3bwo+Pj4gaW50ZXJmYWNlczoKPj4+Cj4+PiAxKSBvbGQgL3Byb2MvaThrIGNoYXIgZGV2aWNl -Cj4+PiAyKSBuZXcgaHdtb24gaW50ZXJmYWNlCj4+Pgo+Pj4gRHJpdmVyIG5vdyBsaXZlcyBpbiBj -aGFyIHN1YnN5c3RlbSwgYnV0IG5vd2FkYXlzIEkgdGhpbmsgbG90Cj4+PiBvZiBwZW9wbGUgYXJl -IGludGVyZXN0ZWQgb25seSBpbiBod21vbiBpbnRlcmZhY2Ugd2hpY2gKPj4+IHByb3ZpZGVzIHRl -bXBlcmF0dXJlICYgZmFuIGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kCj4+PiBob3RrZXlz -IHN1cHBvcnQgKHdoaWNoIGlzIG1pc3NpbmcgaW4gMikgYnV0IHByb3ZpZGVkIGJ5IDEpKQo+Pj4g -aXMgYWxyZWFkeSBoYW5kbGVkIGJ5IEFDUEkgb3IgaW5wdXQgc3Vic3lzdGVtIGZvciBuZXcKPj4+ -IGxhcHRvcHMuCj4+Pgo+Pj4gQWxzbyBuYW1lICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZl -IHdoYXQgaXQgbWVhbnMgYW5kCj4+PiBzdXBwb3J0cy4uLiAoSSB3YXMgdG9sZCBpdCBpcyBhYmJy -ZXZpYXRpb24gZm9yIEluc3Bpcmlvbgo+Pj4gODAwMCBtb2RlbCB3aGljaCB3YXMgcHJvYmFibHkg -Zmlyc3QgZGVsbCBtb2RlbCBzdXBwb3J0ZWQgYnkKPj4+IHRoYXQgREVMTERJQUcgaW50ZXJmYWNl -KS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3RybywKPj4+IExhdGl0dWRlIGFuZCBhbHNvIFBy -ZWNpc2lvbiBhbmQgWFBTIG1vZGVscy4gSSB0aGluayBhdAo+Pj4gbGVhc3QgImRlbGwiIHNob3Vs -ZCBiZSBwYXJ0IG9mIGRyaXZlciBuYW1lIGFuZCBjb25maWcKPj4+IG9wdGlvbi4KPj4+Cj4+PiBT -byBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Pj4KPj4+IDEpIE1vdmUgZHJpdmVyIGZy -b20gY2hhciBzdWJzeXN0ZW0gdG8gaHdtb24KPj4KPj4gSSBhbSBvayB3aXRoIHRoaXMgb25lLgo+ -Pgo+Pj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh -ZyBvcgo+Pj4gZGVsbHNtbQo+Pgo+PiBNaWdodCBiZSBwcm9ibGVtYXRpYywgYXMgaXQgd291bGQg -YnJlYWsgZXhpc3RpbmcKPj4gY29uZmlndXJhdGlvbnMgdW5sZXNzIHlvdSBrZWVwIHRoZSBDT05G -SUdfSThLIGJ1dCByZW5hbWUgdGhlCj4+IGRyaXZlci4gRHJpdmVyIG5hbWVzIGFyZSBuZXZlciBw -ZXJmZWN0LCBzbyBJIHdvdWxkIGp1c3QgbGVhdmUKPj4gaXQgYXMgaXMuCj4+Cj4+PiAzKSBBZGQg -bmV3IENPTkZJR18gb3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UKPj4+ -IGFuZCBjb21waWxlIG9ubHkgaHdtb24gaW50ZXJmYWNlIHN1cHBvcnQKPj4KPj4gTWFrZXMgc2Vu -c2UuIEkgd291bGQgc3VnZ2VzdCB0byBtYWtlIGh3bW9uIHN1cHBwb3J0IHRoZQo+PiBkZWZhdWx0 -IGFuZCBtYW5kYXRvcnkgaWYgdGhlIGRyaXZlciBpcyBlbmFibGVkIGFuZCBhZGQgYSBuZXcKPj4g -Q09ORklHX0k4S19QUk9DSUYgb3Igc2ltaWxhciB3aGljaCBzaG91bGQgYmUgZW5hYmxlZCBieQo+ -PiBkZWZhdWx0Lgo+Pgo+Cj4gV2hhdCBhYm91dCBDT05GSUdfREVMTERJQUcgKG9yIERFTExTTU0g -b3IgQ09ORklHX1NFTlNPUlNfKikgZm9yCj4gbWFuZGF0b3J5IGNvcmUgJiBod21vbiBjb2RlIGFu -ZCAoa2VlcCBleGlzdGluZykgQ09ORklHX0k4SyBmb3IKPiAvcHJvYy9pOGs/Cj4KQ09ORklHX1NF -TlNPUlNfREVMTCB3b3VsZCBwcm9iYWJseSBiZSBiZXN0LCBidXQgdGhhdCB3b3VsZCBzdGlsbApi -cmVhayBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IGZvciBleGlzdGluZyBjb25maWd1cmF0aW9ucyB1 -bmxlc3MKeW91IGVuYWJsZSBDT05GSUdfU0VOU09SU19ERUxMIGJ5IGRlZmF1bHQgd2hpY2ggd291 -bGQgbm90IGJlCmEgZ29vZCBpZGVhLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19f -X19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNv -cnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlz -dGluZm8vbG0tc2Vuc29ycw= +On 02/22/2015 09:44 AM, Pali Rohár wrote: +> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: +>> On 02/22/2015 03:50 AM, Pali Rohár wrote: +>>> Hello, +>>> +>>> currently i8k driver for DELLDIAG SMM operations (charger, +>>> battery, hotkeys, temperature and fan control) supports two +>>> interfaces: +>>> +>>> 1) old /proc/i8k char device +>>> 2) new hwmon interface +>>> +>>> Driver now lives in char subsystem, but nowadays I think lot +>>> of people are interested only in hwmon interface which +>>> provides temperature & fan control. Power management and +>>> hotkeys support (which is missing in 2) but provided by 1)) +>>> is already handled by ACPI or input subsystem for new +>>> laptops. +>>> +>>> Also name "i8k" is really non intuitive what it means and +>>> supports... (I was told it is abbreviation for Inspirion +>>> 8000 model which was probably first dell model supported by +>>> that DELLDIAG interface). Now driver is used on Vostro, +>>> Latitude and also Precision and XPS models. I think at +>>> least "dell" should be part of driver name and config +>>> option. +>>> +>>> So I have idea for some changes: +>>> +>>> 1) Move driver from char subsystem to hwmon +>> +>> I am ok with this one. +>> +>>> 2) Rename driver from i8k to something like delldiag or +>>> dellsmm +>> +>> Might be problematic, as it would break existing +>> configurations unless you keep the CONFIG_I8K but rename the +>> driver. Driver names are never perfect, so I would just leave +>> it as is. +>> +>>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device +>>> and compile only hwmon interface support +>> +>> Makes sense. I would suggest to make hwmon suppport the +>> default and mandatory if the driver is enabled and add a new +>> CONFIG_I8K_PROCIF or similar which should be enabled by +>> default. +>> +> +> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for +> mandatory core & hwmon code and (keep existing) CONFIG_I8K for +> /proc/i8k? +> +CONFIG_SENSORS_DELL would probably be best, but that would still +break backward compatibility for existing configurations unless +you enable CONFIG_SENSORS_DELL by default which would not be +a good idea. + +Guenter diff --git a/a/content_digest b/N1/content_digest index dd7e7e2..b8175fa 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\054EA12DC.1000403@roeck-us.net\0" "ref\0201502221844.54371@pali\0" "From\0Guenter Roeck <linux@roeck-us.net>\0" - "Subject\0Re: [lm-sensors] i8k: move driver from char to hwmon\0" - "Date\0Sun, 22 Feb 2015 17:55:00 +0000\0" + "Subject\0Re: i8k: move driver from char to hwmon\0" + "Date\0Sun, 22 Feb 2015 09:55:00 -0800\0" "To\0Pali Roh\303\241r <pali.rohar@gmail.com>\0" "Cc\0Arnd Bergmann <arnd@arndb.de>" Greg Kroah-Hartman <gregkh@linuxfoundation.org> @@ -16,46 +16,65 @@ " lm-sensors@lm-sensors.org\0" "\00:1\0" "b\0" - "T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy\n" - "IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMDIvMjIv\n" - "MjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4+PiBIZWxsbywKPj4+Cj4+PiBjdXJy\n" - "ZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIsCj4+\n" - "PiBiYXR0ZXJ5LCBob3RrZXlzLCB0ZW1wZXJhdHVyZSBhbmQgZmFuIGNvbnRyb2wpIHN1cHBvcnRz\n" - "IHR3bwo+Pj4gaW50ZXJmYWNlczoKPj4+Cj4+PiAxKSBvbGQgL3Byb2MvaThrIGNoYXIgZGV2aWNl\n" - "Cj4+PiAyKSBuZXcgaHdtb24gaW50ZXJmYWNlCj4+Pgo+Pj4gRHJpdmVyIG5vdyBsaXZlcyBpbiBj\n" - "aGFyIHN1YnN5c3RlbSwgYnV0IG5vd2FkYXlzIEkgdGhpbmsgbG90Cj4+PiBvZiBwZW9wbGUgYXJl\n" - "IGludGVyZXN0ZWQgb25seSBpbiBod21vbiBpbnRlcmZhY2Ugd2hpY2gKPj4+IHByb3ZpZGVzIHRl\n" - "bXBlcmF0dXJlICYgZmFuIGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kCj4+PiBob3RrZXlz\n" - "IHN1cHBvcnQgKHdoaWNoIGlzIG1pc3NpbmcgaW4gMikgYnV0IHByb3ZpZGVkIGJ5IDEpKQo+Pj4g\n" - "aXMgYWxyZWFkeSBoYW5kbGVkIGJ5IEFDUEkgb3IgaW5wdXQgc3Vic3lzdGVtIGZvciBuZXcKPj4+\n" - "IGxhcHRvcHMuCj4+Pgo+Pj4gQWxzbyBuYW1lICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZl\n" - "IHdoYXQgaXQgbWVhbnMgYW5kCj4+PiBzdXBwb3J0cy4uLiAoSSB3YXMgdG9sZCBpdCBpcyBhYmJy\n" - "ZXZpYXRpb24gZm9yIEluc3Bpcmlvbgo+Pj4gODAwMCBtb2RlbCB3aGljaCB3YXMgcHJvYmFibHkg\n" - "Zmlyc3QgZGVsbCBtb2RlbCBzdXBwb3J0ZWQgYnkKPj4+IHRoYXQgREVMTERJQUcgaW50ZXJmYWNl\n" - "KS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3RybywKPj4+IExhdGl0dWRlIGFuZCBhbHNvIFBy\n" - "ZWNpc2lvbiBhbmQgWFBTIG1vZGVscy4gSSB0aGluayBhdAo+Pj4gbGVhc3QgImRlbGwiIHNob3Vs\n" - "ZCBiZSBwYXJ0IG9mIGRyaXZlciBuYW1lIGFuZCBjb25maWcKPj4+IG9wdGlvbi4KPj4+Cj4+PiBT\n" - "byBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Pj4KPj4+IDEpIE1vdmUgZHJpdmVyIGZy\n" - "b20gY2hhciBzdWJzeXN0ZW0gdG8gaHdtb24KPj4KPj4gSSBhbSBvayB3aXRoIHRoaXMgb25lLgo+\n" - "Pgo+Pj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh\n" - "ZyBvcgo+Pj4gZGVsbHNtbQo+Pgo+PiBNaWdodCBiZSBwcm9ibGVtYXRpYywgYXMgaXQgd291bGQg\n" - "YnJlYWsgZXhpc3RpbmcKPj4gY29uZmlndXJhdGlvbnMgdW5sZXNzIHlvdSBrZWVwIHRoZSBDT05G\n" - "SUdfSThLIGJ1dCByZW5hbWUgdGhlCj4+IGRyaXZlci4gRHJpdmVyIG5hbWVzIGFyZSBuZXZlciBw\n" - "ZXJmZWN0LCBzbyBJIHdvdWxkIGp1c3QgbGVhdmUKPj4gaXQgYXMgaXMuCj4+Cj4+PiAzKSBBZGQg\n" - "bmV3IENPTkZJR18gb3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UKPj4+\n" - "IGFuZCBjb21waWxlIG9ubHkgaHdtb24gaW50ZXJmYWNlIHN1cHBvcnQKPj4KPj4gTWFrZXMgc2Vu\n" - "c2UuIEkgd291bGQgc3VnZ2VzdCB0byBtYWtlIGh3bW9uIHN1cHBwb3J0IHRoZQo+PiBkZWZhdWx0\n" - "IGFuZCBtYW5kYXRvcnkgaWYgdGhlIGRyaXZlciBpcyBlbmFibGVkIGFuZCBhZGQgYSBuZXcKPj4g\n" - "Q09ORklHX0k4S19QUk9DSUYgb3Igc2ltaWxhciB3aGljaCBzaG91bGQgYmUgZW5hYmxlZCBieQo+\n" - "PiBkZWZhdWx0Lgo+Pgo+Cj4gV2hhdCBhYm91dCBDT05GSUdfREVMTERJQUcgKG9yIERFTExTTU0g\n" - "b3IgQ09ORklHX1NFTlNPUlNfKikgZm9yCj4gbWFuZGF0b3J5IGNvcmUgJiBod21vbiBjb2RlIGFu\n" - "ZCAoa2VlcCBleGlzdGluZykgQ09ORklHX0k4SyBmb3IKPiAvcHJvYy9pOGs/Cj4KQ09ORklHX1NF\n" - "TlNPUlNfREVMTCB3b3VsZCBwcm9iYWJseSBiZSBiZXN0LCBidXQgdGhhdCB3b3VsZCBzdGlsbApi\n" - "cmVhayBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IGZvciBleGlzdGluZyBjb25maWd1cmF0aW9ucyB1\n" - "bmxlc3MKeW91IGVuYWJsZSBDT05GSUdfU0VOU09SU19ERUxMIGJ5IGRlZmF1bHQgd2hpY2ggd291\n" - "bGQgbm90IGJlCmEgZ29vZCBpZGVhLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19f\n" - "X19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNv\n" - "cnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlz\n" - dGluZm8vbG0tc2Vuc29ycw= + "On 02/22/2015 09:44 AM, Pali Roh\303\241r wrote:\n" + "> On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote:\n" + ">> On 02/22/2015 03:50 AM, Pali Roh\303\241r wrote:\n" + ">>> Hello,\n" + ">>>\n" + ">>> currently i8k driver for DELLDIAG SMM operations (charger,\n" + ">>> battery, hotkeys, temperature and fan control) supports two\n" + ">>> interfaces:\n" + ">>>\n" + ">>> 1) old /proc/i8k char device\n" + ">>> 2) new hwmon interface\n" + ">>>\n" + ">>> Driver now lives in char subsystem, but nowadays I think lot\n" + ">>> of people are interested only in hwmon interface which\n" + ">>> provides temperature & fan control. Power management and\n" + ">>> hotkeys support (which is missing in 2) but provided by 1))\n" + ">>> is already handled by ACPI or input subsystem for new\n" + ">>> laptops.\n" + ">>>\n" + ">>> Also name \"i8k\" is really non intuitive what it means and\n" + ">>> supports... (I was told it is abbreviation for Inspirion\n" + ">>> 8000 model which was probably first dell model supported by\n" + ">>> that DELLDIAG interface). Now driver is used on Vostro,\n" + ">>> Latitude and also Precision and XPS models. I think at\n" + ">>> least \"dell\" should be part of driver name and config\n" + ">>> option.\n" + ">>>\n" + ">>> So I have idea for some changes:\n" + ">>>\n" + ">>> 1) Move driver from char subsystem to hwmon\n" + ">>\n" + ">> I am ok with this one.\n" + ">>\n" + ">>> 2) Rename driver from i8k to something like delldiag or\n" + ">>> dellsmm\n" + ">>\n" + ">> Might be problematic, as it would break existing\n" + ">> configurations unless you keep the CONFIG_I8K but rename the\n" + ">> driver. Driver names are never perfect, so I would just leave\n" + ">> it as is.\n" + ">>\n" + ">>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device\n" + ">>> and compile only hwmon interface support\n" + ">>\n" + ">> Makes sense. I would suggest to make hwmon suppport the\n" + ">> default and mandatory if the driver is enabled and add a new\n" + ">> CONFIG_I8K_PROCIF or similar which should be enabled by\n" + ">> default.\n" + ">>\n" + ">\n" + "> What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for\n" + "> mandatory core & hwmon code and (keep existing) CONFIG_I8K for\n" + "> /proc/i8k?\n" + ">\n" + "CONFIG_SENSORS_DELL would probably be best, but that would still\n" + "break backward compatibility for existing configurations unless\n" + "you enable CONFIG_SENSORS_DELL by default which would not be\n" + "a good idea.\n" + "\n" + Guenter -a7173bf5a5c6aa7e2fa3dd20621c0d7bd9805b2a2f1f187e5b2cd4670e2b3bbb +49bce5f741319d297ad9236f702b4a00ed53d5cf812aca3029104f6cb3c33fae
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.