From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Sun, 22 Feb 2015 17:55:00 +0000 Subject: Re: [lm-sensors] i8k: move driver from char to hwmon Message-Id: <54EA17F4.8000106@roeck-us.net> List-Id: References: <201502221250.49466@pali> <54EA12DC.1000403@roeck-us.net> <201502221844.54371@pali> In-Reply-To: <201502221844.54371@pali> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= Cc: Arnd Bergmann , Greg Kroah-Hartman , Steven Honeyman , Jean Delvare , Valdis.Kletnieks@vt.edu, Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org T24gMDIvMjIvMjAxNSAwOTo0NCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4gT24gU3VuZGF5IDIy IEZlYnJ1YXJ5IDIwMTUgMTg6MzM6MTYgR3VlbnRlciBSb2VjayB3cm90ZToKPj4gT24gMDIvMjIv MjAxNSAwMzo1MCBBTSwgUGFsaSBSb2jDoXIgd3JvdGU6Cj4+PiBIZWxsbywKPj4+Cj4+PiBjdXJy ZW50bHkgaThrIGRyaXZlciBmb3IgREVMTERJQUcgU01NIG9wZXJhdGlvbnMgKGNoYXJnZXIsCj4+ PiBiYXR0ZXJ5LCBob3RrZXlzLCB0ZW1wZXJhdHVyZSBhbmQgZmFuIGNvbnRyb2wpIHN1cHBvcnRz IHR3bwo+Pj4gaW50ZXJmYWNlczoKPj4+Cj4+PiAxKSBvbGQgL3Byb2MvaThrIGNoYXIgZGV2aWNl Cj4+PiAyKSBuZXcgaHdtb24gaW50ZXJmYWNlCj4+Pgo+Pj4gRHJpdmVyIG5vdyBsaXZlcyBpbiBj aGFyIHN1YnN5c3RlbSwgYnV0IG5vd2FkYXlzIEkgdGhpbmsgbG90Cj4+PiBvZiBwZW9wbGUgYXJl IGludGVyZXN0ZWQgb25seSBpbiBod21vbiBpbnRlcmZhY2Ugd2hpY2gKPj4+IHByb3ZpZGVzIHRl bXBlcmF0dXJlICYgZmFuIGNvbnRyb2wuIFBvd2VyIG1hbmFnZW1lbnQgYW5kCj4+PiBob3RrZXlz IHN1cHBvcnQgKHdoaWNoIGlzIG1pc3NpbmcgaW4gMikgYnV0IHByb3ZpZGVkIGJ5IDEpKQo+Pj4g aXMgYWxyZWFkeSBoYW5kbGVkIGJ5IEFDUEkgb3IgaW5wdXQgc3Vic3lzdGVtIGZvciBuZXcKPj4+ IGxhcHRvcHMuCj4+Pgo+Pj4gQWxzbyBuYW1lICJpOGsiIGlzIHJlYWxseSBub24gaW50dWl0aXZl IHdoYXQgaXQgbWVhbnMgYW5kCj4+PiBzdXBwb3J0cy4uLiAoSSB3YXMgdG9sZCBpdCBpcyBhYmJy ZXZpYXRpb24gZm9yIEluc3Bpcmlvbgo+Pj4gODAwMCBtb2RlbCB3aGljaCB3YXMgcHJvYmFibHkg Zmlyc3QgZGVsbCBtb2RlbCBzdXBwb3J0ZWQgYnkKPj4+IHRoYXQgREVMTERJQUcgaW50ZXJmYWNl KS4gTm93IGRyaXZlciBpcyB1c2VkIG9uIFZvc3RybywKPj4+IExhdGl0dWRlIGFuZCBhbHNvIFBy ZWNpc2lvbiBhbmQgWFBTIG1vZGVscy4gSSB0aGluayBhdAo+Pj4gbGVhc3QgImRlbGwiIHNob3Vs ZCBiZSBwYXJ0IG9mIGRyaXZlciBuYW1lIGFuZCBjb25maWcKPj4+IG9wdGlvbi4KPj4+Cj4+PiBT byBJIGhhdmUgaWRlYSBmb3Igc29tZSBjaGFuZ2VzOgo+Pj4KPj4+IDEpIE1vdmUgZHJpdmVyIGZy b20gY2hhciBzdWJzeXN0ZW0gdG8gaHdtb24KPj4KPj4gSSBhbSBvayB3aXRoIHRoaXMgb25lLgo+ Pgo+Pj4gMikgUmVuYW1lIGRyaXZlciBmcm9tIGk4ayB0byBzb21ldGhpbmcgbGlrZSBkZWxsZGlh ZyBvcgo+Pj4gZGVsbHNtbQo+Pgo+PiBNaWdodCBiZSBwcm9ibGVtYXRpYywgYXMgaXQgd291bGQg YnJlYWsgZXhpc3RpbmcKPj4gY29uZmlndXJhdGlvbnMgdW5sZXNzIHlvdSBrZWVwIHRoZSBDT05G SUdfSThLIGJ1dCByZW5hbWUgdGhlCj4+IGRyaXZlci4gRHJpdmVyIG5hbWVzIGFyZSBuZXZlciBw ZXJmZWN0LCBzbyBJIHdvdWxkIGp1c3QgbGVhdmUKPj4gaXQgYXMgaXMuCj4+Cj4+PiAzKSBBZGQg bmV3IENPTkZJR18gb3B0aW9uIHRvIGVuYWJsZS9kaXNhYmxlIC9wcm9jL2k4ayBkZXZpY2UKPj4+ IGFuZCBjb21waWxlIG9ubHkgaHdtb24gaW50ZXJmYWNlIHN1cHBvcnQKPj4KPj4gTWFrZXMgc2Vu c2UuIEkgd291bGQgc3VnZ2VzdCB0byBtYWtlIGh3bW9uIHN1cHBwb3J0IHRoZQo+PiBkZWZhdWx0 IGFuZCBtYW5kYXRvcnkgaWYgdGhlIGRyaXZlciBpcyBlbmFibGVkIGFuZCBhZGQgYSBuZXcKPj4g Q09ORklHX0k4S19QUk9DSUYgb3Igc2ltaWxhciB3aGljaCBzaG91bGQgYmUgZW5hYmxlZCBieQo+ PiBkZWZhdWx0Lgo+Pgo+Cj4gV2hhdCBhYm91dCBDT05GSUdfREVMTERJQUcgKG9yIERFTExTTU0g b3IgQ09ORklHX1NFTlNPUlNfKikgZm9yCj4gbWFuZGF0b3J5IGNvcmUgJiBod21vbiBjb2RlIGFu ZCAoa2VlcCBleGlzdGluZykgQ09ORklHX0k4SyBmb3IKPiAvcHJvYy9pOGs/Cj4KQ09ORklHX1NF TlNPUlNfREVMTCB3b3VsZCBwcm9iYWJseSBiZSBiZXN0LCBidXQgdGhhdCB3b3VsZCBzdGlsbApi cmVhayBiYWNrd2FyZCBjb21wYXRpYmlsaXR5IGZvciBleGlzdGluZyBjb25maWd1cmF0aW9ucyB1 bmxlc3MKeW91IGVuYWJsZSBDT05GSUdfU0VOU09SU19ERUxMIGJ5IGRlZmF1bHQgd2hpY2ggd291 bGQgbm90IGJlCmEgZ29vZCBpZGVhLgoKR3VlbnRlcgoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmxtLXNlbnNvcnMgbWFpbGluZyBsaXN0CmxtLXNlbnNv cnNAbG0tc2Vuc29ycy5vcmcKaHR0cDovL2xpc3RzLmxtLXNlbnNvcnMub3JnL21haWxtYW4vbGlz dGluZm8vbG0tc2Vuc29ycw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752243AbbBVRz5 (ORCPT ); Sun, 22 Feb 2015 12:55:57 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:37594 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752006AbbBVRz4 (ORCPT ); Sun, 22 Feb 2015 12:55:56 -0500 Message-ID: <54EA17F4.8000106@roeck-us.net> Date: Sun, 22 Feb 2015 09:55:00 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: =?UTF-8?B?UGFsaSBSb2jDoXI=?= CC: Arnd Bergmann , Greg Kroah-Hartman , Steven Honeyman , Jean Delvare , Valdis.Kletnieks@vt.edu, Jochen Eisinger , Gabriele Mazzotta , linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org Subject: Re: i8k: move driver from char to hwmon References: <201502221250.49466@pali> <54EA12DC.1000403@roeck-us.net> <201502221844.54371@pali> In-Reply-To: <201502221844.54371@pali> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020202.54EA182B.0102,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/22/2015 09:44 AM, Pali Rohár wrote: > On Sunday 22 February 2015 18:33:16 Guenter Roeck wrote: >> On 02/22/2015 03:50 AM, Pali Rohár wrote: >>> Hello, >>> >>> currently i8k driver for DELLDIAG SMM operations (charger, >>> battery, hotkeys, temperature and fan control) supports two >>> interfaces: >>> >>> 1) old /proc/i8k char device >>> 2) new hwmon interface >>> >>> Driver now lives in char subsystem, but nowadays I think lot >>> of people are interested only in hwmon interface which >>> provides temperature & fan control. Power management and >>> hotkeys support (which is missing in 2) but provided by 1)) >>> is already handled by ACPI or input subsystem for new >>> laptops. >>> >>> Also name "i8k" is really non intuitive what it means and >>> supports... (I was told it is abbreviation for Inspirion >>> 8000 model which was probably first dell model supported by >>> that DELLDIAG interface). Now driver is used on Vostro, >>> Latitude and also Precision and XPS models. I think at >>> least "dell" should be part of driver name and config >>> option. >>> >>> So I have idea for some changes: >>> >>> 1) Move driver from char subsystem to hwmon >> >> I am ok with this one. >> >>> 2) Rename driver from i8k to something like delldiag or >>> dellsmm >> >> Might be problematic, as it would break existing >> configurations unless you keep the CONFIG_I8K but rename the >> driver. Driver names are never perfect, so I would just leave >> it as is. >> >>> 3) Add new CONFIG_ option to enable/disable /proc/i8k device >>> and compile only hwmon interface support >> >> Makes sense. I would suggest to make hwmon suppport the >> default and mandatory if the driver is enabled and add a new >> CONFIG_I8K_PROCIF or similar which should be enabled by >> default. >> > > What about CONFIG_DELLDIAG (or DELLSMM or CONFIG_SENSORS_*) for > mandatory core & hwmon code and (keep existing) CONFIG_I8K for > /proc/i8k? > CONFIG_SENSORS_DELL would probably be best, but that would still break backward compatibility for existing configurations unless you enable CONFIG_SENSORS_DELL by default which would not be a good idea. Guenter