From: Jes Sorensen <jes.sorensen@gmail.com>
To: "Hatice ERTÜRK" <haticeerturk27@gmail.com>,
outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: Deleted space prohibited between function name and open parenthesis
Date: Sun, 22 Feb 2015 13:30:41 -0500 [thread overview]
Message-ID: <54EA2051.707@gmail.com> (raw)
In-Reply-To: <1424629071-15794-1-git-send-email-haticeerturk27@gmail.com>
On 02/22/15 13:17, Hatice ERTÜRK wrote:
> WARNING: space prohibited between function name and open parenthesis '('
>
> Remove unnecessary space between function name and opening parenthesis.
>
> That was found by running checkpatch
>
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
> drivers/staging/rtl8723au/core/rtw_ap.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Patch looks good - next time Put your own message first in the commit,
and the 'WARNING....' portion after where you write 'This was found by
running checkpatch'.
You don't need to resubmit this one.
Cheers,
Jes
> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 04717dc..87728b9 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -1642,7 +1642,7 @@ u8 ap_free_sta23a(struct rtw_adapter *padapter, struct sta_info *psta, bool acti
> return beacon_updated;
> }
>
> -int rtw_ap_inform_ch_switch23a (struct rtw_adapter *padapter, u8 new_ch, u8 ch_offset)
> +int rtw_ap_inform_ch_switch23a(struct rtw_adapter *padapter, u8 new_ch, u8 ch_offset)
> {
> struct list_head *phead, *plist;
> struct sta_info *psta = NULL;
> @@ -1663,12 +1663,12 @@ int rtw_ap_inform_ch_switch23a (struct rtw_adapter *padapter, u8 new_ch, u8 ch_o
> list_for_each(plist, phead) {
> psta = container_of(plist, struct sta_info, asoc_list);
>
> - issue_action_spct_ch_switch23a (padapter, psta->hwaddr, new_ch, ch_offset);
> + issue_action_spct_ch_switch23a(padapter, psta->hwaddr, new_ch, ch_offset);
> psta->expire_to = ((pstapriv->expire_to * 2) > 5) ? 5 : (pstapriv->expire_to * 2);
> }
> spin_unlock_bh(&pstapriv->asoc_list_lock);
>
> - issue_action_spct_ch_switch23a (padapter, bc_addr, new_ch, ch_offset);
> + issue_action_spct_ch_switch23a(padapter, bc_addr, new_ch, ch_offset);
>
> return 0;
> }
> @@ -1871,7 +1871,7 @@ void stop_ap_mode23a(struct rtw_adapter *padapter)
> pmlmeext->bstart_bss = false;
>
> /* reset and init security priv , this can refine with rtw_reset_securitypriv23a */
> - memset((unsigned char *)&padapter->securitypriv, 0, sizeof (struct security_priv));
> + memset((unsigned char *)&padapter->securitypriv, 0, sizeof(struct security_priv));
> padapter->securitypriv.ndisauthtype = Ndis802_11AuthModeOpen;
> padapter->securitypriv.ndisencryptstatus = Ndis802_11WEPDisabled;
>
>
prev parent reply other threads:[~2015-02-22 18:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-22 18:17 [PATCH] Staging: rtl8723au: core: Deleted space prohibited between function name and open parenthesis Hatice ERTÜRK
2015-02-22 18:30 ` Jes Sorensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EA2051.707@gmail.com \
--to=jes.sorensen@gmail.com \
--cc=haticeerturk27@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.