Re: [Outreachy kernel] [PATCH] Staging: rtl8723au: core: coding style ether_addr_copy

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/22/15 13:04, Hatice ERTÜRK wrote:
> This fixes the following issues detected by checkpatch.pl:
> 
> WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)
> 
> Signed-off-by: Hatice ERTURK <haticeerturk27@gmail.com>
> ---
>  drivers/staging/rtl8723au/core/rtw_ap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Seems fine - did you verify that the structures are aligned correctly?

Cheers,
Jes


> diff --git a/drivers/staging/rtl8723au/core/rtw_ap.c b/drivers/staging/rtl8723au/core/rtw_ap.c
> index 59d08f4..04717dc 100644
> --- a/drivers/staging/rtl8723au/core/rtw_ap.c
> +++ b/drivers/staging/rtl8723au/core/rtw_ap.c
> @@ -817,7 +817,7 @@ int rtw_check_beacon_data23a(struct rtw_adapter *padapter,
>  
>  	pbss_network->Rssi = 0;
>  
> -	memcpy(pbss_network->MacAddress, myid(&padapter->eeprompriv), ETH_ALEN);
> +	ether_addr_copy(pbss_network->MacAddress, myid(&padapter->eeprompriv));
>  
>  	/* SSID */
>  	p = rtw_get_ie23a(ie, WLAN_EID_SSID, &ie_len, pbss_network->IELength);
> @@ -1079,7 +1079,7 @@ int rtw_acl_add_sta23a(struct rtw_adapter *padapter, u8 *addr)
>  		if (!paclnode->valid) {
>  			INIT_LIST_HEAD(&paclnode->list);
>  
> -			memcpy(paclnode->addr, addr, ETH_ALEN);
> +			ether_addr_copy(paclnode->addr, addr);
>  
>  			paclnode->valid = true;
>  
>