Re: [PATCH net-next] bridge: add vlan info to bridge setlink and dellink notification messages

[roopa <roopa@cumulusnetworks.com>]

On 2/22/15, 8:02 PM, David Miller wrote:
> From: roopa@cumulusnetworks.com
> Date: Sat, 21 Feb 2015 20:21:51 -0800
>
>> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>>
>> vlan add/deletes are not notified to userspace today. This patch adds
>> vlan info to bridge newlink/dellink notifications generated from the bridge
>> driver. Notifications use the RTEXT_FILTER_BRVLAN_COMPRESSED flag to compress vlans into ranges whereever applicable.
> Please format your commit message text to ~80 columns in the
> future, thanks.

sorry abt that. ack, thanks.
>
>> The size calculations does not take ranges into account for simplicity.
>> This has the potential for allocating a larger skb than required.
>>
>> There is an existing inconsistency with bridge NEWLINK and
>> DELLINK change notifications. Both generate NEWLINK notifications.
>> Since its always a NEWLINK notification, this patch includes all
>> vlans the port belongs to in the notification. The NEWLINK and DELLINK
>> request messages however only include the vlans to be added and
>> deleted.
>>
>> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
> This looks fine to me, applied.
>
> If you would put at least some time into trying to reduce the
> allocation size, taking range compression into consideration,
> I'd very much appreciate it as a follow-on patch.
will do, thanks.