From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: tim@xen.org, xen-devel@lists.xen.org, keir@xen.org,
ian.jackson@eu.citrix.com, ian.campbell@citrix.com
Subject: Re: [PATCH] xen: Minor modifications to platform.h to make it C++-friendly
Date: Mon, 23 Feb 2015 13:24:29 +0200 [thread overview]
Message-ID: <54EB0DED.1000201@bitdefender.com> (raw)
In-Reply-To: <54EB14D902000078000626B5@mail.emea.novell.com>
On 02/23/2015 12:54 PM, Jan Beulich wrote:
> I'm not convinced we need the headers to be C++ ready (nor am
> I convinced that there aren't any other obstacles preventing their
> unmodified use in C++).
Sorry, I meant to answer the last part too. I'm using libxc and xenstore
headers, as well as the public Xen headers with C++, and so far the only
trouble I've had was what this patch is addressing, and there's
something called "private" (a macro or a variable, I don't remember
exactly) which is a keyword in C++. I've done the following to work
around that:
extern "C" {
#include <xenstore.h>
#define private rprivate /* private is a C++ keyword */
#include <xen/mem_event.h>
#undef private
}
I've understood Tim's message about "extern "C"" so I've fixed it at
#include-time in my code. :)
HTH,
Razvan
prev parent reply other threads:[~2015-02-23 11:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 9:34 [PATCH] xen: Minor modifications to platform.h to make it C++-friendly Razvan Cojocaru
2015-02-23 10:16 ` Jan Beulich
2015-02-23 10:31 ` Razvan Cojocaru
2015-02-23 10:54 ` Jan Beulich
2015-02-23 11:05 ` Razvan Cojocaru
2015-02-23 11:16 ` Jan Beulich
2015-02-23 11:09 ` Tim Deegan
2015-02-23 11:24 ` Jan Beulich
2015-02-23 11:24 ` Razvan Cojocaru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54EB0DED.1000201@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.