From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling Date: Mon, 23 Feb 2015 13:23:21 +0100 Message-ID: <54EB1BB9.4030205@suse.de> References: <1424283959-16289-3-git-send-email-afaerber@suse.de> <1424373526-4135-1-git-send-email-afaerber@suse.de> <54E6A9AB.4070401@gmail.com> <54EAE4DF.3040607@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <54EAE4DF.3040607-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Javier Martinez Canillas , Tushar Behera , Sangbeom Kim , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , Vincent Palatin , Lars-Peter Clausen , Takashi Iwai , Xiubo Li , Liam Girdwood , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Mark Brown , Tomasz Figa , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Tushar Behera List-Id: alsa-devel@alsa-project.org Hi, Am 23.02.2015 um 09:29 schrieb Javier Martinez Canillas: > On 02/20/2015 04:27 AM, Tushar Behera wrote: >> On 02/20/2015 12:48 AM, Andreas F=C3=A4rber wrote: >>> If master clock is provided through device tree, then update >>> the master clock frequency during set_sysclk. >>> >>> Cc: Tushar Behera >>> Signed-off-by: Andreas F=C3=A4rber >>> --- >>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >> >> Looks good. >> >> Acked-by: Tushar Behera >> >=20 > Looks good to me as well. >=20 > Reviewed-by: Javier Martinez Canillas Thanks guys. One self-doubt: Is there any downside to returning -EPROBE_DEFER after regcache_mark_dirty(max98088->regmap)? I.e., should I move the last hunk some lines up to be the very first thing executed? Cheers, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmany= u, Graham Norton; HRB 21284 (AG N=C3=BCrnberg) -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: afaerber@suse.de (=?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?=) Date: Mon, 23 Feb 2015 13:23:21 +0100 Subject: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling In-Reply-To: <54EAE4DF.3040607@collabora.co.uk> References: <1424283959-16289-3-git-send-email-afaerber@suse.de> <1424373526-4135-1-git-send-email-afaerber@suse.de> <54E6A9AB.4070401@gmail.com> <54EAE4DF.3040607@collabora.co.uk> Message-ID: <54EB1BB9.4030205@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, Am 23.02.2015 um 09:29 schrieb Javier Martinez Canillas: > On 02/20/2015 04:27 AM, Tushar Behera wrote: >> On 02/20/2015 12:48 AM, Andreas F?rber wrote: >>> If master clock is provided through device tree, then update >>> the master clock frequency during set_sysclk. >>> >>> Cc: Tushar Behera >>> Signed-off-by: Andreas F?rber >>> --- >>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >> >> Looks good. >> >> Acked-by: Tushar Behera >> > > Looks good to me as well. > > Reviewed-by: Javier Martinez Canillas Thanks guys. One self-doubt: Is there any downside to returning -EPROBE_DEFER after regcache_mark_dirty(max98088->regmap)? I.e., should I move the last hunk some lines up to be the very first thing executed? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany GF: Felix Imend?rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N?rnberg) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752383AbbBWMXh (ORCPT ); Mon, 23 Feb 2015 07:23:37 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49260 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbbBWMXf (ORCPT ); Mon, 23 Feb 2015 07:23:35 -0500 Message-ID: <54EB1BB9.4030205@suse.de> Date: Mon, 23 Feb 2015 13:23:21 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Organization: SUSE Linux GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Javier Martinez Canillas , Tushar Behera , Sangbeom Kim , alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org CC: devicetree@vger.kernel.org, Doug Anderson , Vincent Palatin , Lars-Peter Clausen , Takashi Iwai , Xiubo Li , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Tomasz Figa , linux-arm-kernel@lists.infradead.org, Tushar Behera Subject: Re: [alsa-devel] [PATCH] ASoC: max98088: Add master clock handling References: <1424283959-16289-3-git-send-email-afaerber@suse.de> <1424373526-4135-1-git-send-email-afaerber@suse.de> <54E6A9AB.4070401@gmail.com> <54EAE4DF.3040607@collabora.co.uk> In-Reply-To: <54EAE4DF.3040607@collabora.co.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Am 23.02.2015 um 09:29 schrieb Javier Martinez Canillas: > On 02/20/2015 04:27 AM, Tushar Behera wrote: >> On 02/20/2015 12:48 AM, Andreas Färber wrote: >>> If master clock is provided through device tree, then update >>> the master clock frequency during set_sysclk. >>> >>> Cc: Tushar Behera >>> Signed-off-by: Andreas Färber >>> --- >>> sound/soc/codecs/max98088.c | 24 ++++++++++++++++++++++++ >>> 1 file changed, 24 insertions(+) >>> >> >> Looks good. >> >> Acked-by: Tushar Behera >> > > Looks good to me as well. > > Reviewed-by: Javier Martinez Canillas Thanks guys. One self-doubt: Is there any downside to returning -EPROBE_DEFER after regcache_mark_dirty(max98088->regmap)? I.e., should I move the last hunk some lines up to be the very first thing executed? Cheers, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG Nürnberg)