From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH v2] complete conversion set_bit() ->
 __cpumask_set_cpu() by 4aaca0e9cd
Date: Mon, 23 Feb 2015 13:49:50 +0000
Message-ID: <54EB2FFE.7000904@citrix.com>
References: <54EB3D880200007800062834@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1YPtOY-0008QJ-Kk
	for xen-devel@lists.xenproject.org; Mon, 23 Feb 2015 13:49:58 +0000
In-Reply-To: <54EB3D880200007800062834@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xenproject.org>
Cc: Ian Campbell <Ian.Campbell@eu.citrix.com>, Sander Eikelenboom <linux@eikelenboom.it>, Keir Fraser <keir@xen.org>, Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>
List-Id: xen-devel@lists.xenproject.org

On 23/02/15 13:47, Jan Beulich wrote:
> While converting to __cpumask_set_cpu() was correct, the first argument
> passed should have been corrected to be "cpu" instead of "nr" at once.
> The wrong construct results in problems on systems with relatively few
> CPUs.
>
> Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Looks better.

Reviewed-by: Andrew Cooper <andrew.cooper3@citirx.com>

> ---
> v2: As Andrew points out the original code was wrong too, and hence
>     the use of __cpumask_set_cpu) was correct. What was wrong was the
>     use of "nr" as the bit position.
>
> --- a/xen/common/softirq.c
> +++ b/xen/common/softirq.c
> @@ -106,7 +106,7 @@ void cpu_raise_softirq(unsigned int cpu,
>      if ( !per_cpu(batching, this_cpu) || in_irq() )
>          smp_send_event_check_cpu(cpu);
>      else
> -        __cpumask_set_cpu(nr, &per_cpu(batch_mask, this_cpu));
> +        __cpumask_set_cpu(cpu, &per_cpu(batch_mask, this_cpu));
>  }
>  
>  void cpu_raise_softirq_batch_begin(void)
>
>
>