From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 Date: Wed, 25 Feb 2015 23:26:29 -0800 (PST) From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Cc: navyasri.tech@gmail.com Message-Id: <326a6742-203a-4632-a8d6-4098f739e751@googlegroups.com> In-Reply-To: <54EB83B0.3090505@gmail.com> References: <0103912c5f48fa319b9503c985a2fd28952e2b90.1424683660.git.navyasri.tech@gmail.com> <54EB83B0.3090505@gmail.com> Subject: Re: [Outreachy kernel] [PATCH v3 2/4] staging: rtl8192u: Clean-up comment line style MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_3487_1457458177.1424935589058" X-Google-Token: EKWVu6cF_PCovnLj1yo0 X-Google-IP: 111.93.6.70 ------=_Part_3487_1457458177.1424935589058 Content-Type: multipart/alternative; boundary="----=_Part_3488_1301103157.1424935589058" ------=_Part_3488_1301103157.1424935589058 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Tuesday, February 24, 2015 at 1:16:58 AM UTC+5:30, jes.sorensen wrote: > > On 02/23/15 04:51, Navya Sri Nizamkari wrote: > > Convert style of comment from C99 to C89 to fix the > > following checkpatch.pl error: > > > > ERROR: "Do not use C99 // comments" > > > > Signed-off-by: Navya Sri Nizamkari > > > --- > > Changes in v3: > > -None in this file of the patchset > > > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > index eb89321..bcb2479 100644 > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > > @@ -11,7 +11,7 @@ > > * > > */ > > > > -//#include > > +/* #include */ > > #include > > #include > > #include > > > > This is dead code, rather than changing the comment style, you should > remove the line completely. > > Cheers, > Jes > > Hi, I sent in the older version of this patch by mistake. I sent a newer version of the patchset. Navya ------=_Part_3488_1301103157.1424935589058 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit


On Tuesday, February 24, 2015 at 1:16:58 AM UTC+5:30, jes.sorensen wrote:
On 02/23/15 04:51, Navya Sri Nizamkari wrote:
> Convert style of comment from C99 to C89 to fix the
> following checkpatch.pl error:
>
> ERROR: "Do not use C99 // comments"
>
> Signed-off-by: Navya Sri Nizamkari <navyas...@gmail.com>
> ---
> Changes in v3:
>     -None in this file of the patchset
>
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> index eb89321..bcb2479 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c
> @@ -11,7 +11,7 @@
>   *
>   */
>  
> -//#include <linux/config.h>
> +/* #include <linux/config.h> */
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
>

This is dead code, rather than changing the comment style, you should
remove the line completely.

Cheers,
Jes


Hi,
I sent in the older version of this patch by mistake. I sent a newer version of the patchset.
Navya 
------=_Part_3488_1301103157.1424935589058-- ------=_Part_3487_1457458177.1424935589058-- From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.50.23.75 with SMTP id k11mr13042454igf.3.1424720985866; Mon, 23 Feb 2015 11:49:45 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.38.74 with SMTP id m71ls1703063iom.109.gmail; Mon, 23 Feb 2015 11:49:45 -0800 (PST) X-Received: by 10.66.196.11 with SMTP id ii11mr13659130pac.37.1424720985653; Mon, 23 Feb 2015 11:49:45 -0800 (PST) Return-Path: Received: from mail-qa0-x236.google.com (mail-qa0-x236.google.com. [2607:f8b0:400d:c00::236]) by gmr-mx.google.com with ESMTPS id e5si3607477qcg.1.2015.02.23.11.49.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:49:45 -0800 (PST) Received-SPF: pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c00::236 as permitted sender) client-ip=2607:f8b0:400d:c00::236; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c00::236 as permitted sender) smtp.mail=jes.sorensen@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-qa0-f54.google.com with SMTP id x12so23807361qac.13 for ; Mon, 23 Feb 2015 11:49:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:message-id:date:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=k5WAz0SccnOQylkl6Iq8yp/oSgYoFer2AC1eNUluR1Q=; b=EUK1aopFAXXf/fgnWCirlXgHMbtFsab+/Qk5oPZHCLBCOgCAtHFKZ6329bAjTW2/Oh 5m9ERPAGbErxjplddE32dCOR4gPk+4P0qyeijGkerqoPhJnr7z50kg8mYK0u8FJTqYBE qqG57OrO/+1i0pmfrkyyZPnF/RZFwndkqmXKNF1AGGR5oge+G/fvCzJAfv/T1B84QWsa EFcUS0VzLAaqDW36A1J9DtzqVMEYDp4hi5AXD+/ehsBnVFHeuEZSAqaANpfyeVArIUV0 VSH91/u0x5+fFzAadAUbJ+RPRloFL9vYs4PiekRu4MN4uYgJC7uySCtEX73PH1rwoWsE m9FQ== X-Received: by 10.140.98.35 with SMTP id n32mr19123151qge.62.1424720985505; Mon, 23 Feb 2015 11:49:45 -0800 (PST) Return-Path: Received: from [10.15.49.233] (nat-pool-rdu-t.redhat.com. [66.187.233.202]) by mx.google.com with ESMTPSA id f20sm10862425qax.37.2015.02.23.11.49.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:49:44 -0800 (PST) From: Jes Sorensen X-Google-Original-From: Jes Sorensen Message-ID: <54EB8457.3010108@gmail.com> Date: Mon, 23 Feb 2015 14:49:43 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Navya Sri Nizamkari , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v3 4/4] staging: rtl8192u: Fix quoted string split across lines. References: <6583fe4c851d1364e66448ecf733b693200f56d0.1424683660.git.navyasri.tech@gmail.com> In-Reply-To: <6583fe4c851d1364e66448ecf733b693200f56d0.1424683660.git.navyasri.tech@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/23/15 04:54, Navya Sri Nizamkari wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: quoted string split across lines > > Signed-off-by: Navya Sri Nizamkari > --- > Changes in v3: > -None in this patch. > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > index 0aed175..c81193b 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data) > spin_lock_irqsave(&ieee->lock, flags); > ieee80211_crypt_deinit_entries(ieee, 0); > if (!list_empty(&ieee->crypt_deinit_list)) { > - netdev_dbg(ieee->dev, "entries remaining in delayed crypt " > - "deletion list\n"); > + netdev_dbg(ieee->dev, > + "entries remaining in delayed crypt deletion list\n"); The principle of your changes is good, but you need to get the indentation right. If you put an argument to a function on the next line, it needs to line up with the first argument of the function. netdev_dbg(foo, very_long_argument_that_should_not_break_lines); This is the same in all the cases below as well. Jes > ieee->crypt_deinit_timer.expires = jiffies + HZ; > add_timer(&ieee->crypt_deinit_timer); > } > @@ -146,8 +146,8 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops) > spin_unlock_irqrestore(&hcrypt->lock, flags); > > if (del_alg) { > - pr_debug("ieee80211_crypt: unregistered algorithm " > - "'%s'\n", ops->name); > + pr_debug("ieee80211_crypt: unregistered algorithm '%s'\n", > + ops->name); > kfree(del_alg); > } > > @@ -232,8 +232,8 @@ void __exit ieee80211_crypto_deinit(void) > struct ieee80211_crypto_alg *alg = > (struct ieee80211_crypto_alg *) ptr; > list_del(ptr); > - pr_debug("ieee80211_crypt: unregistered algorithm " > - "'%s' (deinit)\n", alg->ops->name); > + pr_debug("ieee80211_crypt: unregistered algorithm '%s' (deinit)\n", > + alg->ops->name); > kfree(alg); > } > > From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.66.102.66 with SMTP id fm2mr13755364pab.4.1424720842838; Mon, 23 Feb 2015 11:47:22 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.182.73.197 with SMTP id n5ls769112obv.54.gmail; Mon, 23 Feb 2015 11:47:22 -0800 (PST) X-Received: by 10.182.205.232 with SMTP id lj8mr13249984obc.39.1424720842572; Mon, 23 Feb 2015 11:47:22 -0800 (PST) Return-Path: Received: from mail-qc0-x22e.google.com (mail-qc0-x22e.google.com. [2607:f8b0:400d:c01::22e]) by gmr-mx.google.com with ESMTPS id q2si6440731qcn.2.2015.02.23.11.47.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:47:22 -0800 (PST) Received-SPF: pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c01::22e as permitted sender) client-ip=2607:f8b0:400d:c01::22e; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c01::22e as permitted sender) smtp.mail=jes.sorensen@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-qc0-x22e.google.com with SMTP id s11so12933649qcv.8 for ; Mon, 23 Feb 2015 11:47:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:message-id:date:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=7pV24b0cUuI6UqnP0Z2m6TcQxtt1mf8rElaWaFsH2Vg=; b=FpidFftiO9RfD+smVjcBEbQa6sje6vZE/0fflM35uZKSvA/vSzDjGwK4/uMuiLwkpg c3v2aMYVAJYfn6ljzP1TQkYXk0PozJUnCZn+2YTjbGqyt8xwwnSGzBNibioq9QlS0LxC SBxYyTuWHXVS2KjapXDGchUnuojQscy7aeuZdR9+5E5Rvyya/igRzdiRbG5PITol9l/A q92lrhikSdxPgP5vNQ1rNlqwEj2VK2+Z/7H/O7rCRwBSEsa0pO+J1mm4q/72QwwPKaGS d6yuo6a4ktf/fssiiaRKcgK3uq2iY3bGsrK3kI7QnTLba8Ad4zekHOECe8KOjPxqtqdw u21Q== X-Received: by 10.140.82.71 with SMTP id g65mr26979941qgd.42.1424720842442; Mon, 23 Feb 2015 11:47:22 -0800 (PST) Return-Path: Received: from [10.15.49.233] (nat-pool-rdu-t.redhat.com. [66.187.233.202]) by mx.google.com with ESMTPSA id 191sm18048961qht.13.2015.02.23.11.47.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:47:21 -0800 (PST) From: Jes Sorensen X-Google-Original-From: Jes Sorensen Message-ID: <54EB83C8.5030605@gmail.com> Date: Mon, 23 Feb 2015 14:47:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Navya Sri Nizamkari , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v3 3/4] staging: rtl8192u: Replace asm header files with linux ones. References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/23/15 04:53, Navya Sri Nizamkari wrote: > As asm header files are included in linux header files, this patch > uses instead of and > instead of to fix checkpatch.pl errors: > > ERROR: Use #include instead of > ERROR: Use #include instead of > > Signed-off-by: Navya Sri Nizamkari > --- > Changes in v3: > -None. > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This part looks good. Jes > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > index bcb2479..0aed175 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > @@ -15,8 +15,8 @@ > #include > #include > #include > -#include > -#include > +#include > +#include > > #include "ieee80211.h" > > From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Google-Groups: outreachy-kernel X-Google-Thread: 9ca63f596c,25a6457a67aef068 X-Google-Attributes: gid9ca63f596c,domainid0,private,googlegroup X-Google-NewGroupId: yes X-Received: by 10.236.24.228 with SMTP id x64mr13488346yhx.26.1424720818952; Mon, 23 Feb 2015 11:46:58 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.50.253.2 with SMTP id zw2ls811957igc.41.canary; Mon, 23 Feb 2015 11:46:58 -0800 (PST) X-Received: by 10.66.171.9 with SMTP id aq9mr13809514pac.20.1424720818585; Mon, 23 Feb 2015 11:46:58 -0800 (PST) Return-Path: Received: from mail-qg0-x234.google.com (mail-qg0-x234.google.com. [2607:f8b0:400d:c04::234]) by gmr-mx.google.com with ESMTPS id ba9si6221866qcb.0.2015.02.23.11.46.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:46:58 -0800 (PST) Received-SPF: pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c04::234 as permitted sender) client-ip=2607:f8b0:400d:c04::234; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of jes.sorensen@gmail.com designates 2607:f8b0:400d:c04::234 as permitted sender) smtp.mail=jes.sorensen@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-qg0-x234.google.com with SMTP id h3so26189875qgf.11 for ; Mon, 23 Feb 2015 11:46:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:message-id:date:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=moeBCB37HsV8D3Q66qc4Z1Z5WfmYS+Pm1Vy0jggLPMA=; b=pR12SK7LqroqbfhEPz5MlOqQWjQLeKhJnyNp8/vXGReUixRRw9S1uf4XJafpH6tr1w MgpfTy+xkzdNOn0zJ8VVrcHSJmotNxrFj6fEFkK/378KQIiaLU5ws6FnAkS0R7QC0GN1 LwAcP0J+WL6Sk7MyG59ok0zK6N3zgAKNXtZPeYlEr6bBtO/v6U1PjbMXiir9qeDJ4jWu WS12ztr0Rd0u5bXauH7uTyS6Y0xFllb//Uo16/ia3iLhM0MAPxy3vrp4Cn9UjugkVlh9 gEFAD9O2Y1x76WSw9lUUu4Yhuwp5TmrJgklQVtiPPTgzl2Latxh7nZXHAYctYS4KO44A Pd5g== X-Received: by 10.140.92.33 with SMTP id a30mr26996492qge.30.1424720818467; Mon, 23 Feb 2015 11:46:58 -0800 (PST) Return-Path: Received: from [10.15.49.233] (nat-pool-rdu-t.redhat.com. [66.187.233.202]) by mx.google.com with ESMTPSA id b204sm18059981qhc.27.2015.02.23.11.46.57 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 11:46:57 -0800 (PST) From: Jes Sorensen X-Google-Original-From: Jes Sorensen Message-ID: <54EB83B0.3090505@gmail.com> Date: Mon, 23 Feb 2015 14:46:56 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Navya Sri Nizamkari , outreachy-kernel@googlegroups.com Subject: Re: [Outreachy kernel] [PATCH v3 2/4] staging: rtl8192u: Clean-up comment line style References: <0103912c5f48fa319b9503c985a2fd28952e2b90.1424683660.git.navyasri.tech@gmail.com> In-Reply-To: <0103912c5f48fa319b9503c985a2fd28952e2b90.1424683660.git.navyasri.tech@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 02/23/15 04:51, Navya Sri Nizamkari wrote: > Convert style of comment from C99 to C89 to fix the > following checkpatch.pl error: > > ERROR: "Do not use C99 // comments" > > Signed-off-by: Navya Sri Nizamkari > --- > Changes in v3: > -None in this file of the patchset > > drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > index eb89321..bcb2479 100644 > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c > @@ -11,7 +11,7 @@ > * > */ > > -//#include > +/* #include */ > #include > #include > #include > This is dead code, rather than changing the comment style, you should remove the line completely. Cheers, Jes From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Google-Groups: outreachy-kernel X-Google-Thread: 9ca63f596c,25a6457a67aef068 X-Google-Attributes: gid9ca63f596c,domainid0,private,googlegroup X-Google-NewGroupId: yes X-Received: by 10.182.191.65 with SMTP id gw1mr11423048obc.40.1424685208841; Mon, 23 Feb 2015 01:53:28 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.107.9.210 with SMTP id 79ls1498800ioj.41.gmail; Mon, 23 Feb 2015 01:53:28 -0800 (PST) X-Received: by 10.66.140.66 with SMTP id re2mr10999281pab.29.1424685208648; Mon, 23 Feb 2015 01:53:28 -0800 (PST) Return-Path: Received: from mail-pd0-x236.google.com (mail-pd0-x236.google.com. [2607:f8b0:400e:c02::236]) by gmr-mx.google.com with ESMTPS id xj4si3781589pbc.2.2015.02.23.01.53.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 01:53:28 -0800 (PST) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::236 as permitted sender) client-ip=2607:f8b0:400e:c02::236; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::236 as permitted sender) smtp.mail=navyasri.tech@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by pdjg10 with SMTP id g10so24339144pdj.1 for ; Mon, 23 Feb 2015 01:53:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=dS1sJiVBgLSZQj+UO/64sXTG/a0I106wHoCYquhW2o8=; b=QGRrOL24G6YgXCEj+RwI7X66XIdQPtntJhbdKo3rHMQt+qxdry1jmHbLUuJ4Y+90LG zmMPo/X0wVjcltbGJHg3a5bBUOR6w81XJmwNl85zKaYdzxOSaQ0Q2uRkIV+bsP8e1Obd FrQFEbU2ftf5JJsmv0SXuxqe7t39CyBbVqbxmhvJkByoJLavK9QBkGgdTn4giPZK1qVX dVaWyyGwqwpKbPgC+LLhu0Hz20y967okBUgb8OAJsitMqIXmmO8049t4erloBGxpBsIn 0p57TjLDwupialdn28u2b98Z0cx/mcdCHMn4vTT15tefRpQbKuwIRgnStO7EO2TvOnJL rBZQ== X-Received: by 10.70.26.100 with SMTP id k4mr17770176pdg.125.1424685208518; Mon, 23 Feb 2015 01:53:28 -0800 (PST) Return-Path: Received: from nizamkari ([111.93.6.70]) by mx.google.com with ESMTPSA id lq2sm35386666pab.34.2015.02.23.01.53.27 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Feb 2015 01:53:28 -0800 (PST) Date: Mon, 23 Feb 2015 15:24:30 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Subject: [PATCH v3 4/4] staging: rtl8192u: Fix quoted string split across lines. Message-ID: <6583fe4c851d1364e66448ecf733b693200f56d0.1424683660.git.navyasri.tech@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) This patch fixes the checkpatch.pl warning: WARNING: quoted string split across lines Signed-off-by: Navya Sri Nizamkari --- Changes in v3: -None in this patch. drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index 0aed175..c81193b 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data) spin_lock_irqsave(&ieee->lock, flags); ieee80211_crypt_deinit_entries(ieee, 0); if (!list_empty(&ieee->crypt_deinit_list)) { - netdev_dbg(ieee->dev, "entries remaining in delayed crypt " - "deletion list\n"); + netdev_dbg(ieee->dev, + "entries remaining in delayed crypt deletion list\n"); ieee->crypt_deinit_timer.expires = jiffies + HZ; add_timer(&ieee->crypt_deinit_timer); } @@ -146,8 +146,8 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops) spin_unlock_irqrestore(&hcrypt->lock, flags); if (del_alg) { - pr_debug("ieee80211_crypt: unregistered algorithm " - "'%s'\n", ops->name); + pr_debug("ieee80211_crypt: unregistered algorithm '%s'\n", + ops->name); kfree(del_alg); } @@ -232,8 +232,8 @@ void __exit ieee80211_crypto_deinit(void) struct ieee80211_crypto_alg *alg = (struct ieee80211_crypto_alg *) ptr; list_del(ptr); - pr_debug("ieee80211_crypt: unregistered algorithm " - "'%s' (deinit)\n", alg->ops->name); + pr_debug("ieee80211_crypt: unregistered algorithm '%s' (deinit)\n", + alg->ops->name); kfree(alg); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.43.65.211 with SMTP id xn19mr11862151icb.0.1424685118294; Mon, 23 Feb 2015 01:51:58 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.84.116 with SMTP id k107ls2100962qgd.91.gmail; Mon, 23 Feb 2015 01:51:58 -0800 (PST) X-Received: by 10.236.42.228 with SMTP id j64mr11121038yhb.36.1424685118132; Mon, 23 Feb 2015 01:51:58 -0800 (PST) Return-Path: Received: from mail-pd0-x235.google.com (mail-pd0-x235.google.com. [2607:f8b0:400e:c02::235]) by gmr-mx.google.com with ESMTPS id ks4si4141982pbc.1.2015.02.23.01.51.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 01:51:58 -0800 (PST) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::235 as permitted sender) client-ip=2607:f8b0:400e:c02::235; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::235 as permitted sender) smtp.mail=navyasri.tech@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by pdbfl12 with SMTP id fl12so24261746pdb.2 for ; Mon, 23 Feb 2015 01:51:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=H4hYaro3n54pdG73v4dm0sAg+fCvH/Z3Dsv0vpSr3RI=; b=tWgwIne4/p4hxnNg32nQ4LqhKrD/qhpeBJX0ptGr+QzMYMWxbtWRvGCGsZhPbY+YrX 4ILDVbE2bMquyQe54TwCq86sLwlF/Qu0CH1IEcA6ScMNxsl0fOzPk1fQQhprcnfcpUn7 lsQQFm0rm3BoKsPzaBD8G/UZyOB+Ohuln/Qaltmnx7El81PSRb/dSj+uwQP9UQRmba+2 dX8OtFTU8JNw1SDiEbkq9mN7vrDU0cnvFl6cPjV25oPCdi98X0xykN4WhaYZ5QhpRGZc yfi5+r8aqjJ8SMnVf/42OX1k0s0hGWSEx+OZ7vFgSGePUkN/dF6hG4t0sXSmCPQWC8rM /OIA== X-Received: by 10.70.91.49 with SMTP id cb17mr17872560pdb.35.1424685118016; Mon, 23 Feb 2015 01:51:58 -0800 (PST) Return-Path: Received: from nizamkari ([111.93.6.70]) by mx.google.com with ESMTPSA id or4sm35060958pdb.66.2015.02.23.01.51.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Feb 2015 01:51:57 -0800 (PST) Date: Mon, 23 Feb 2015 15:23:00 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Subject: [PATCH v3 3/4] staging: rtl8192u: Replace asm header files with linux ones. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) As asm header files are included in linux header files, this patch uses instead of and instead of to fix checkpatch.pl errors: ERROR: Use #include instead of ERROR: Use #include instead of Signed-off-by: Navya Sri Nizamkari --- Changes in v3: -None. drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index bcb2479..0aed175 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c @@ -15,8 +15,8 @@ #include #include #include -#include -#include +#include +#include #include "ieee80211.h" -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.70.45.49 with SMTP id j17mr6206516pdm.4.1424684999290; Mon, 23 Feb 2015 01:49:59 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.50.114.167 with SMTP id jh7ls847082igb.36.gmail; Mon, 23 Feb 2015 01:49:59 -0800 (PST) X-Received: by 10.68.194.97 with SMTP id hv1mr11055456pbc.0.1424684999044; Mon, 23 Feb 2015 01:49:59 -0800 (PST) Return-Path: Received: from mail-pd0-x236.google.com (mail-pd0-x236.google.com. [2607:f8b0:400e:c02::236]) by gmr-mx.google.com with ESMTPS id bo1si4139718pbc.0.2015.02.23.01.49.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 01:49:59 -0800 (PST) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::236 as permitted sender) client-ip=2607:f8b0:400e:c02::236; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::236 as permitted sender) smtp.mail=navyasri.tech@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-pd0-x236.google.com with SMTP id fp1so24203063pdb.9 for ; Mon, 23 Feb 2015 01:49:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=W5Q5P2X4RXskSHJJKzE9JvcLkgdCzd3l+cavEambaic=; b=K2vUKgntTrdE98zbEgsr2SfFy4BFaSwz2RNq7WJe4HT0qleoKMZ6YQ1BINI/+54Xs0 jPizlDzHmRLfwIxLecafc0nYrho+CXvM0tld4ew6D93ippPsKQeEO2oh1w97DtbYl/5x q3J2vsm5luI+GbeHcbjbsQ9tO3BiO+Oz0IsjL5IKWT7+ys5bYjLDcdeYuJj9LXFmkMyt 3T8z4X4BLy1kJ+d+o2xUH4jeswGiLcme71nv46d432C0OJDROB/u4OvmfZxLFWXeot8y axug/JdBRyzK4zpS5GnPqByFHMbAAUruiImLqEG5LTPwQQdgeecgfj5GrEctyXB4YQo0 WePQ== X-Received: by 10.66.142.131 with SMTP id rw3mr17953014pab.34.1424684998968; Mon, 23 Feb 2015 01:49:58 -0800 (PST) Return-Path: Received: from nizamkari ([111.93.6.70]) by mx.google.com with ESMTPSA id kp1sm34921227pbd.54.2015.02.23.01.49.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Feb 2015 01:49:58 -0800 (PST) Date: Mon, 23 Feb 2015 15:21:00 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Subject: [PATCH v3 2/4] staging: rtl8192u: Clean-up comment line style Message-ID: <0103912c5f48fa319b9503c985a2fd28952e2b90.1424683660.git.navyasri.tech@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Convert style of comment from C99 to C89 to fix the following checkpatch.pl error: ERROR: "Do not use C99 // comments" Signed-off-by: Navya Sri Nizamkari --- Changes in v3: -None in this file of the patchset drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index eb89321..bcb2479 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c @@ -11,7 +11,7 @@ * */ -//#include +/* #include */ #include #include #include -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.140.149.78 with SMTP id 75mr11069622qhv.9.1424684916520; Mon, 23 Feb 2015 01:48:36 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.81.163 with SMTP id f32ls2183271qgd.84.gmail; Mon, 23 Feb 2015 01:48:36 -0800 (PST) X-Received: by 10.236.229.233 with SMTP id h99mr10996717yhq.42.1424684916386; Mon, 23 Feb 2015 01:48:36 -0800 (PST) Return-Path: Received: from mail-pd0-x230.google.com (mail-pd0-x230.google.com. [2607:f8b0:400e:c02::230]) by gmr-mx.google.com with ESMTPS id m1si17197pdc.0.2015.02.23.01.48.36 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 01:48:36 -0800 (PST) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::230 as permitted sender) client-ip=2607:f8b0:400e:c02::230; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c02::230 as permitted sender) smtp.mail=navyasri.tech@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-pd0-x230.google.com with SMTP id z10so24146805pdj.12 for ; Mon, 23 Feb 2015 01:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:references:mime-version :content-type:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=RcOQHQMk3/3jZFBG9fzhF0xFqP1mVrgcR5vh70BSDGs=; b=j/O5WU2A5OD9zruVU69uyK4wOVasEaRifRO88jH9IbOHztC3sjPJ5P1kf6T5b+Iipy +47XlOeOWadIsJk1kxfodhcuJghVR/Q0ysCPA1VAWkn4rCW+z2KixxreAYXRHNgOIbWZ sI4cOItWGL3PBQUMMkmOPAgT2MhqN3l8kTg7IdwET2O5/FSzZ2xQZ89LvadJivF5l4Wi UWhWWf7gtO3cZJawdhUv4OvnxPw1FVdQMC4kjWUfZkmxbAEDI6TVOPN7bg0oKw7aDxjn SVZBpuX1CaNhQCFrgBDqRcJ51Yn14sSry3vyM+vkYM2cSNRtyZVfrP23tEJvDUK+uc2l nBQQ== X-Received: by 10.70.128.231 with SMTP id nr7mr18339761pdb.116.1424684916246; Mon, 23 Feb 2015 01:48:36 -0800 (PST) Return-Path: Received: from nizamkari ([111.93.6.70]) by mx.google.com with ESMTPSA id qz3sm35358776pab.13.2015.02.23.01.48.35 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Feb 2015 01:48:35 -0800 (PST) Date: Mon, 23 Feb 2015 15:19:38 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Subject: [PATCH v3 1/4] staging: rtl8192u: Convert from printk into netdev_dbg or pr_debug. Message-ID: <98deaa0c6c3f0623fa6a0c1479d3d3f69ff4884c.1424683660.git.navyasri.tech@gmail.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) As this is a network driver file, convert printk(KERN_DEBUG.. ) to netdev_dbg if the calling function has arguments to support it else to pr_debug , to fix the checkpatch.pl warning: WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... Signed-off-by: Navya Sri Nizamkari Changes in v2: - Correct the commit message to be clearer. --- Changes in v3: - Change pr_dbg to pr_debug as it gives the following warning: implicit declaration of function ‘pr_dbg’ and update subject to reflect the change. Changes in v2: - Correct the commit message to be clearer. drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c index 5533221..eb89321 100644 --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c @@ -66,8 +66,8 @@ void ieee80211_crypt_deinit_handler(unsigned long data) spin_lock_irqsave(&ieee->lock, flags); ieee80211_crypt_deinit_entries(ieee, 0); if (!list_empty(&ieee->crypt_deinit_list)) { - printk(KERN_DEBUG "%s: entries remaining in delayed crypt " - "deletion list\n", ieee->dev->name); + netdev_dbg(ieee->dev, "entries remaining in delayed crypt " + "deletion list\n"); ieee->crypt_deinit_timer.expires = jiffies + HZ; add_timer(&ieee->crypt_deinit_timer); } @@ -118,7 +118,7 @@ int ieee80211_register_crypto_ops(struct ieee80211_crypto_ops *ops) list_add(&alg->list, &hcrypt->algs); spin_unlock_irqrestore(&hcrypt->lock, flags); - printk(KERN_DEBUG "ieee80211_crypt: registered algorithm '%s'\n", + pr_debug("ieee80211_crypt: registered algorithm '%s'\n", ops->name); return 0; @@ -146,7 +146,7 @@ int ieee80211_unregister_crypto_ops(struct ieee80211_crypto_ops *ops) spin_unlock_irqrestore(&hcrypt->lock, flags); if (del_alg) { - printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm " + pr_debug("ieee80211_crypt: unregistered algorithm " "'%s'\n", ops->name); kfree(del_alg); } @@ -232,7 +232,7 @@ void __exit ieee80211_crypto_deinit(void) struct ieee80211_crypto_alg *alg = (struct ieee80211_crypto_alg *) ptr; list_del(ptr); - printk(KERN_DEBUG "ieee80211_crypt: unregistered algorithm " + pr_debug("ieee80211_crypt: unregistered algorithm " "'%s' (deinit)\n", alg->ops->name); kfree(alg); } -- 1.9.1 From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 2517133950976 X-Received: by 10.42.16.141 with SMTP id p13mr11404941ica.6.1424684572259; Mon, 23 Feb 2015 01:42:52 -0800 (PST) X-BeenThere: outreachy-kernel@googlegroups.com Received: by 10.140.87.119 with SMTP id q110ls2244799qgd.15.gmail; Mon, 23 Feb 2015 01:42:52 -0800 (PST) X-Received: by 10.140.149.78 with SMTP id 75mr11054035qhv.9.1424684572096; Mon, 23 Feb 2015 01:42:52 -0800 (PST) Return-Path: Received: from mail-pa0-x230.google.com (mail-pa0-x230.google.com. [2607:f8b0:400e:c03::230]) by gmr-mx.google.com with ESMTPS id bo1si4137003pbc.0.2015.02.23.01.42.52 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 01:42:52 -0800 (PST) Received-SPF: pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::230 as permitted sender) client-ip=2607:f8b0:400e:c03::230; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of navyasri.tech@gmail.com designates 2607:f8b0:400e:c03::230 as permitted sender) smtp.mail=navyasri.tech@gmail.com; dkim=pass header.i=@gmail.com; dmarc=pass (p=NONE dis=NONE) header.from=gmail.com Received: by mail-pa0-x230.google.com with SMTP id lf10so26197047pab.6 for ; Mon, 23 Feb 2015 01:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:subject:message-id:mime-version:content-type :content-disposition:user-agent; bh=WdUE7mayHNXFfS7WGnOoju4Y7r5b5zqDro5OI+/L4Ec=; b=sIJwYx1djJfxH/9xcUTui7P2weFEF9GsXFKnLjwK3KcBezFufpA8F6KlHa9TJ6LRVK XppQZaMlSGVYiDMNU9clkqLsYGxJW1M9kDgYCHTFGWFveE3hSQNZ2WmyyFcXpO9TmIMN ezaakmxdGWmb0h+t6McqIjhQ/YxrgsvfzGOsJ1+bMsq57Y0Z648AndPt2AoaqpOF2No3 hlZ3SPGMxyqh/cMrDv1hDfFEgQKWszDho23UGhU4Nn0PghGp+mBQom67GKd8wn3ACBUd H8i0Q9mLNjZkrmCJVU4Uf8sjKd5irWJp/3qWBGSqAxrYEfpon+wZuzySDyhEte8HgBtf s9Rg== X-Received: by 10.70.88.71 with SMTP id be7mr17482596pdb.41.1424684571919; Mon, 23 Feb 2015 01:42:51 -0800 (PST) Return-Path: Received: from nizamkari ([61.16.142.166]) by mx.google.com with ESMTPSA id lq2sm35353450pab.34.2015.02.23.01.42.50 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 23 Feb 2015 01:42:51 -0800 (PST) Date: Mon, 23 Feb 2015 15:13:54 +0530 From: Navya Sri Nizamkari To: outreachy-kernel@googlegroups.com Subject: [PATCH v3 0/4] staging: rtl8192u: Fix warnings in ieee80211_crypt.c Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) [changes in v3] In v3 version, the printk functions which are changed to pr_dbg are changed to pr_debug as pr_dbg gives a 'implicit declaration of function' warning when you build. [changes in v2] In v2 version of this patchset I correct the commit message of [PATCH 1/4] to be clearer and remove a comment from [PATCH 2/4] whose style was changed in version v1. [original cover letter] This patchset removes an unnecessary comment and clears checkpatch.pl warnings in ieee80211_crypt.c such as: convert printk to a preferable function like netdev_dbg or pr_dbg, replace asm header files with linux ones, fix the quoted string split across a line. Navya Sri Nizamkari (4): staging: rtl8192u: Convert from printk into netdev_dbg or pr_dbg staging: rtl8192u: Clean-up comment line style staging: rtl8192u: Replace asm header files with linux ones. staging: rtl8192u: Fix quoted string split across lines. drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) -- 1.9.1