Re: [Outreachy kernel] [PATCH v2] Staging: rtl8192u: Convert comments from C99 to C89 style

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/23/15 14:32, Ksenija Stanojevic wrote:
> Kernel style for comments is C89 style. Issue found by checkpatch.pl.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
> ---
> v2: remove space before tab
> 
>  drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> index 7ed7243..44a9e3d 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h
> @@ -1,14 +1,14 @@
>  #ifndef _TSTYPE_H_
>  #define _TSTYPE_H_
>  #include "rtl819x_Qos.h"
> -#define TS_SETUP_TIMEOUT	60  // In millisecond
> +#define TS_SETUP_TIMEOUT	60  /*  In millisecond */

Please only one space after the /*

>  #define TS_INACT_TIMEOUT	60
>  #define TS_ADDBA_DELAY		60
>  
>  #define TOTAL_TS_NUM		16
>  #define TCLAS_NUM		4
>  
> -// This define the Tx/Rx directions
> +/*  This define the Tx/Rx directions */

Same here

>  typedef enum _TR_SELECT {
>  	TX_DIR = 0,
>  	RX_DIR = 1,
> @@ -28,9 +28,9 @@ typedef struct _TS_COMMON_INFO{
>  typedef struct _TX_TS_RECORD{
>  	TS_COMMON_INFO		TsCommonInfo;
>  	u16				TxCurSeq;
> -	BA_RECORD			TxPendingBARecord;	// For BA Originator
> -	BA_RECORD			TxAdmittedBARecord;	// For BA Originator
> -//	QOS_DL_RECORD		DLRecord;
> +	BA_RECORD			TxPendingBARecord;	/*  For BA Originator */
> +	BA_RECORD			TxAdmittedBARecord;	/*  For BA Originator */
> +/*	QOS_DL_RECORD		DLRecord; */

The last line is not a comment, but disabling a variable. In this case
you should remove the variable from the struct instead of changing the
comment style as it's dead code.

>  	u8				bAddBaReqInProgress;
>  	u8				bAddBaReqDelayed;
>  	u8				bUsingBa;
> @@ -44,11 +44,11 @@ typedef struct _RX_TS_RECORD {
>  	u16				RxTimeoutIndicateSeq;
>  	struct list_head		RxPendingPktList;
>  	struct timer_list		RxPktPendingTimer;
> -	BA_RECORD			RxAdmittedBARecord;	 // For BA Recipient
> +	BA_RECORD			RxAdmittedBARecord;	 /*  For BA Recipient */

Again the issue with two spaces

>  	u16				RxLastSeqNum;
>  	u8				RxLastFragNum;
>  	u8				num;
> -//	QOS_DL_RECORD		DLRecord;
> +/*	QOS_DL_RECORD		DLRecord; */

And another case of dead code.

>  } RX_TS_RECORD, *PRX_TS_RECORD;
>  
>  
> 

Cheers,
Jes