Re: [Outreachy kernel] [PATCH] Staging: rtl8192u: Replace printk() with pr_debug()

[Jes Sorensen <jes.sorensen@gmail.com>]

On 02/23/15 14:57, Ksenija Stanojević wrote:
> Ok, thank you for telling me. i didn't notice that I included changes
> to both files!

It is a good idea to inspect patch files visually before you post them
to catch such things.

Again here, please do not top-post replies in email.

Cheers,
Jes


> On Mon, Feb 23, 2015 at 8:45 PM, Jes Sorensen <jes.sorensen@gmail.com> wrote:
>> On 02/22/15 15:36, Ksenija Stanojevic wrote:
>>> For dynamic debugging pr_debug() macro is preferred over printk(), which
>>> is the raw way to print something. Issue found by checkpatch.pl.
>>>
>>> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>>> ---
>>>  drivers/dma/ste_dma40.c                                  | 1 +
>>>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 4 ++--
>>>  2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> The fix to rtl8192u is correct, but you managed to include a change to
>> drivers/dma/ste_dma40.c in the same patch. That is not good - you need
>> to repost a v2, which only includes the rtl8192u changes.
>>
>> Cheers,
>> Jes
>>
>>
>>> diff --git a/drivers/dma/ste_dma40.c b/drivers/dma/ste_dma40.c
>>> index 15d4946..8adae93 100644
>>> --- a/drivers/dma/ste_dma40.c
>>> +++ b/drivers/dma/ste_dma40.c
>>> @@ -23,6 +23,7 @@
>>>  #include <linux/amba/bus.h>
>>>  #include <linux/regulator/consumer.h>
>>>  #include <linux/platform_data/dma-ste-dma40.h>
>>> +#include <linux/sizes.h>
>>>
>>>  #include "dmaengine.h"
>>>  #include "ste_dma40_ll.h"
>>> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>>> index 8c1bf1f..7fab680 100644
>>> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>>> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
>>> @@ -49,14 +49,14 @@ static void *prism2_wep_init(int keyidx)
>>>
>>>       priv->tx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
>>>       if (IS_ERR(priv->tx_tfm)) {
>>> -             printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
>>> +             pr_debug("ieee80211_crypt_wep: could not allocate "
>>>                      "crypto API arc4\n");
>>>               priv->tx_tfm = NULL;
>>>               goto fail;
>>>       }
>>>       priv->rx_tfm = crypto_alloc_blkcipher("ecb(arc4)", 0, CRYPTO_ALG_ASYNC);
>>>       if (IS_ERR(priv->rx_tfm)) {
>>> -             printk(KERN_DEBUG "ieee80211_crypt_wep: could not allocate "
>>> +             pr_debug("ieee80211_crypt_wep: could not allocate "
>>>                      "crypto API arc4\n");
>>>               priv->rx_tfm = NULL;
>>>               goto fail;
>>>
>>