Re: [Outreachy kernel] [PATCH] Staging: iio: Move export_symbol below its function

[Preeti U Murthy <preeti@linux.vnet.ibm.com>]

Hi Melike,

On 02/24/2015 04:48 AM, Melike Yurtoglu wrote:
> WARNING: "EXPORT_SYMBOL(foo); should immediately follow its
> function/variable"
> That was found by running checkpatch.
> 
> Signed-off-by: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com>
> ---
>  drivers/staging/iio/addac/adt7316.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/addac/adt7316.c b/drivers/staging/iio/addac/adt7316.c
> index 5b11b42..18bfbf0 100644
> --- a/drivers/staging/iio/addac/adt7316.c
> +++ b/drivers/staging/iio/addac/adt7316.c
> @@ -2069,6 +2069,7 @@ static struct attribute_group adt7516_event_attribute_group = {
>  };
> 
>  #ifdef CONFIG_PM_SLEEP
> +EXPORT_SYMBOL_GPL(adt7316_pm_ops);
>  static int adt7316_disable(struct device *dev)
>  {
>  	struct iio_dev *dev_info = dev_get_drvdata(dev);
> @@ -2086,7 +2087,6 @@ static int adt7316_enable(struct device *dev)
>  }
> 
>  SIMPLE_DEV_PM_OPS(adt7316_pm_ops, adt7316_disable, adt7316_enable);
> -EXPORT_SYMBOL_GPL(adt7316_pm_ops);

The EXPORT_SYMBOL() is rightly under the variable definition -
adt7316_pm_ops. So why this cleanup?

Regards
Preeti U Murthy
>  #endif
> 
>  static const struct iio_info adt7316_info = {
>