From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH] xsm/flask: Handle policy load failures properly Date: Tue, 24 Feb 2015 09:31:38 +0000 Message-ID: <54EC44FA.2090005@linaro.org> References: <1424707899-18101-1-git-send-email-dgdegra@tycho.nsa.gov> <20150223164823.GD20083@zion.uk.xensource.com> <54EB6930.2040703@tycho.nsa.gov> <1424767648.32223.3.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YQBqA-0006Ym-O0 for xen-devel@lists.xenproject.org; Tue, 24 Feb 2015 09:31:42 +0000 Received: by mail-wi0-f172.google.com with SMTP id l15so23903165wiw.5 for ; Tue, 24 Feb 2015 01:31:41 -0800 (PST) In-Reply-To: <1424767648.32223.3.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Daniel De Graaf Cc: xen-devel@lists.xenproject.org, Wei Liu List-Id: xen-devel@lists.xenproject.org On 24/02/2015 08:47, Ian Campbell wrote: > On Mon, 2015-02-23 at 12:53 -0500, Daniel De Graaf wrote: >> When no policy is loaded, the FLASK policy is equivalent to an allow-all >> policy; see xen/xsm/flask/ss/services.c:security_compute_av where it >> bails out if !ss_initialized. It could be considered as either enforcing >> or being permissive with an allow-all policy, but the actual access is >> the same. > > Do you think anyone would want an option to be provided which causes Xen > to fail to boot if a proper policy isn't provided (and loaded)? Similar > to how iommu=force works. > > I can see how osstest testcases for xsm might want this to avoid > accidentally testing with no policy, but not sure if it would be > considered generally useful enough to be added. I think it would make sense to panic when flask_enforcing is enabled and the policy is not loaded or valid. Regards, -- Julien Grall