From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH v1] xen/arm: Do not allocate pte entries for
 MAP_SMALL_PAGES
Date: Tue, 24 Feb 2015 10:17:15 +0000
Message-ID: <54EC5DBB0200007800062FEE@mail.emea.novell.com>
References: <1424264213-30614-1-git-send-email-vijay.kilari@gmail.com>
	<54E48DAB.5030307@linaro.org> <1424770282.27930.259.camel@citrix.com>
	<54EC4699.8050905@linaro.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <54EC4699.8050905@linaro.org>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Julien Grall <julien.grall@linaro.org>
Cc: Ian Campbell <ian.campbell@citrix.com>, vijay.kilari@gmail.com, stefano.stabellini@eu.citrix.com, Prasun.Kapoor@caviumnetworks.com, manish.jaggi@caviumnetworks.com, tim@xen.org, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, vijaya.kumar@caviumnetworks.com
List-Id: xen-devel@lists.xenproject.org

>>> On 24.02.15 at 10:38, <julien.grall@linaro.org> wrote:
> On 24/02/2015 09:31, Ian Campbell wrote:
>> On Wed, 2015-02-18 at 13:03 +0000, Julien Grall wrote:
>>>> +                {
>>>> +                    pte = mfn_to_xen_entry(mfn, (ai & 0xffff));
>>>
>>> Please introduce a new macro for the mask.
>>
>> Better would be a pte_foo accessor, similar (if not identical) to x86's
>> pte_get_flags. So pte_get_flags(ai) or so.
> 
> I'm not able to find a such function in x86. Did you intend to mean 
> pte_flags_to_cacheattr?

get_pte_flags()

Jan