Re: [PATCH net-next] i40e: mark constant as ULL

[Stefan Assmann <sassmann@kpanic.de>]

On 23.02.2015 15:56, Stefan Assmann wrote:
> On 04.02.2015 18:49, Jeff Kirsher wrote:
>> On Wed, 2015-02-04 at 12:41 +0100, Stefan Assmann wrote:
>>> This avoids a compile error on 32bit.
>>>
>>> Signed-off-by: Stefan Assmann <sassmann@kpanic.de>
>>> ---
>>>  drivers/net/ethernet/intel/i40e/i40e_lan_hmc.c | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> Come to find out, I already have a fix in my queue for this.  So I will
>> be dropping your patch.
>>
>> The patch in my queue fixes the issue by doing the folling change:
>> -               mask = 0xFFFFFFFFFFFFFFFF;
>> +               mask = ~(u64)0;
>>
> 
> Jeff,
> 
> this does not seem to compile on 32bit either. Please verify and if
> you agree let's put my patch back in place instead of this one. IIRC
> your patch has not been posted yet.
> 
>   Stefan
> 

Jeff,

I fat fingered this, everything ok. Please ignore my last comment.

  Stefan