From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH v3 08/13] xen/arm: Describe device supported by a driver with dt_match_node Date: Tue, 24 Feb 2015 14:42:47 +0000 Message-ID: <54EC8DE7.8070802@linaro.org> References: <1422643768-23614-1-git-send-email-julien.grall@linaro.org> <1422643768-23614-9-git-send-email-julien.grall@linaro.org> <1424435413.30924.207.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YQGhl-0003me-Dn for xen-devel@lists.xenproject.org; Tue, 24 Feb 2015 14:43:21 +0000 Received: by wghk14 with SMTP id k14so5724318wgh.3 for ; Tue, 24 Feb 2015 06:43:15 -0800 (PST) In-Reply-To: <1424435413.30924.207.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: xen-devel@lists.xenproject.org, tim@xen.org, stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 20/02/15 12:30, Ian Campbell wrote: > On Fri, 2015-01-30 at 18:49 +0000, Julien Grall wrote: > > Subject: "devices" > >> Xen is currently using list a compatible string to know if the driver > > "using a list of compatible strings" > > rather than "if the driver can use device node" I'd say something like > "to match drivers against device nodes". The second part is better. I will use it. >> can use device node. This leads to have double definition in the GIC >> code. > > "having double definitions". > > (aside: can we eventually get rid of that duplication somehow?) I was able to get a rid of the multiple way to define the "list of compatible string" (see asm-arm/gic.h). I will give a look to get a rid of the multiple usage (domain_build.c and gic-v*.c) by introducing a GIC callback. Though, it will be a follow-up of this patch and I may send it separately. >> Futhermore Linux drivers is using dt_match_node (actually called of_device_id > > "Furthermore" and "are using" > >> in Linux) to list device supported by the drivers. > > "devices" > > I'd append one more sentence, something like "Remove the existing > compatible field and replace with a dt_match field". Just to make it > clear what the change here is. I will do. >> >> Signed-off-by: Julien Grall >> Acked-by: Stefano Stabellini > > The actual code looks fine, with the commit message fixed up as > described: > > Acked-by: Ian Campbell Thanks, -- Julien Grall