All of lore.kernel.org
 help / color / mirror / Atom feed
From: Josh Hunt <johunt@akamai.com>
To: Thomas Graf <tgraf@suug.ch>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
	Patrick McHardy <kaber@trash.net>,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v2 2/2] nft_hash: define max_shift rhashtable parameter
Date: Tue, 24 Feb 2015 11:03:01 -0600	[thread overview]
Message-ID: <54ECAEC5.6040307@akamai.com> (raw)
In-Reply-To: <20150224164219.GC21107@casper.infradead.org>

On 02/24/2015 10:42 AM, Thomas Graf wrote:
> Maybe this should be called .._MAX_BUCKETS instead, the table
> itself does not have a upper nelements limit but will not grow
> above 16M buckets as the comment states correctly already.
>
> After this change:
> Acked-by: Thomas Graf <tgraf@suug.ch>
>

Sure I can change the name to NFT_HASH_MAX_BUCKETS.

Thanks
Josh

      reply	other threads:[~2015-02-24 17:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-24 16:10 [PATCH v2 0/2] nft hash resize fixes Josh Hunt
2015-02-24 16:10 ` [PATCH v2 1/2] rhashtable: require max_shift if grow_decision defined Josh Hunt
2015-02-24 16:40   ` Thomas Graf
2015-02-24 18:18   ` David Miller
2015-02-24 19:48     ` Daniel Borkmann
2015-02-24 21:31       ` David Miller
2015-02-24 22:49         ` Thomas Graf
2015-02-25  2:12           ` David Miller
2015-02-24 22:36     ` Josh Hunt
2015-02-24 16:10 ` [PATCH v2 2/2] nft_hash: define max_shift rhashtable parameter Josh Hunt
2015-02-24 16:42   ` Thomas Graf
2015-02-24 17:03     ` Josh Hunt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ECAEC5.6040307@akamai.com \
    --to=johunt@akamai.com \
    --cc=daniel@iogearbox.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.