From: "H. Peter Anvin" <hpa@zytor.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Borislav Petkov <bp@suse.de>,
hpa@linux.intel.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, mingo@kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86/asm: Add support for the pcommit instruction
Date: Tue, 24 Feb 2015 13:52:22 -0800 [thread overview]
Message-ID: <54ECF296.3030301@zytor.com> (raw)
In-Reply-To: <1424814530.6833.11.camel@theros.lm.intel.com>
On 02/24/2015 01:48 PM, Ross Zwisler wrote:
> On Tue, 2015-02-24 at 13:41 -0800, H. Peter Anvin wrote:
>> On 02/24/2015 01:40 PM, H. Peter Anvin wrote:
>>> On 02/24/2015 01:30 AM, Borislav Petkov wrote:
>>>> On Mon, Feb 23, 2015 at 03:14:01PM -0800, H. Peter Anvin wrote:
>>>>> That may cause the same line to be flushed twice. I would suggest,
>>>>> instead, also removing the arithmetic on void *:
>>>>
>>>> Btw, should we hold down all those suggested usages somewhere in
>>>> Documentation/x86/ as commit messages are generally harder to find?
>>>>
>>>
>>> Yes, and commit messages can't be corrected after the fact.
>>>
>>
>> Either that, or perhaps even better in kerneldoc comments in the source
>> itself.
>
> Either sounds like a good idea to me. :) Let me know which you'd prefer
> and I'll get something written up.
>
Kerneldoc would be better, as it is more likely to be maintained in
proximity for the source.
-hpa
prev parent reply other threads:[~2015-02-24 21:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 17:37 [PATCH v4] x86: Add support for the pcommit instruction Ross Zwisler
2015-02-20 10:31 ` [tip:x86/asm] x86/asm: " tip-bot for Ross Zwisler
2015-02-23 23:14 ` H. Peter Anvin
2015-02-24 9:30 ` Borislav Petkov
2015-02-24 21:40 ` H. Peter Anvin
2015-02-24 21:41 ` H. Peter Anvin
2015-02-24 21:48 ` Ross Zwisler
2015-02-24 21:52 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ECF296.3030301@zytor.com \
--to=hpa@zytor.com \
--cc=bp@suse.de \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=ross.zwisler@linux.intel.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.